Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window buttons appear in white with the light colour theme [Windows] #21

Closed
acorazza opened this issue Aug 5, 2021 · 10 comments
Closed

Comments

@acorazza
Copy link

acorazza commented Aug 5, 2021

First off - great theme, thank you!

The minimize/maximize/close buttons on Windows don't seem to change colour when the Light theme is active. Screenshot below:

image

@sotakal
Copy link

sotakal commented Aug 20, 2021

Can confirm the same. I've tried switching the system theme, tinkering with Obsidian and the Minimal Theme settings, but this is still a problem.

@acorazza
Copy link
Author

acorazza commented Aug 23, 2021

I have a partial fix - the hover on the X isn't perfect but at least the buttons can be made visible by adding this line to the titlebar-button class.

.titlebar-button {
  color:var(--text-muted);
}

@acorazza
Copy link
Author

acorazza commented Aug 24, 2021

A few more fixes. This works as one would expect, hover and all.

.titlebar-button {
  color:var(--text-muted);
}
.titlebar-button:hover {
  background-color: var(--background-primary-alt);
}
.mod-close:hover svg {
  fill:white !important;
  stroke:white !important;
}

@kepano
Copy link
Owner

kepano commented Aug 27, 2021

Can you try the latest and see if it works for you? Unfortunately I don't have a Windows machine to test on. I am adding .mod-windows to the rules as well. See the commit: 40799de

@acorazza
Copy link
Author

It mostly works, the only issue is hovering over the X button makes it "blank".

.mod-windows .titlebar-button:hover {
    background-color: var(--background-primary-alt);
}

Is overriding this (correct) value:

.titlebar-button.mod-close:hover {
    background-color: var(--background-modifier-error);
}

@kepano
Copy link
Owner

kepano commented Aug 27, 2021

Ok please try again with the latest, thank you! See b550038

@acorazza
Copy link
Author

image

Perfect! And it works as expected in Dark Mode as well. Thank you!

@acorazza
Copy link
Author

BTW I'm happy to contribute to the project if you could use someone to test things on Windows.

@kepano
Copy link
Owner

kepano commented Aug 27, 2021

Thanks!

@kepano kepano closed this as completed Aug 27, 2021
@animusastralis
Copy link

I'm not sure if this issue was fixed earlier, but it's still present in v7.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants