Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Typo3 12 support #21

Open
ifre opened this issue Mar 23, 2023 · 18 comments
Open

[FEATURE] Typo3 12 support #21

ifre opened this issue Mar 23, 2023 · 18 comments

Comments

@ifre
Copy link

ifre commented Mar 23, 2023

Hi,
is a Typo3 12 support planned?
An Update would made my day. :D

Thanks a lot

@Kephson
Copy link
Owner

Kephson commented May 6, 2023

Hi, yes it's planned and I was asked to add a feature request for TYPO3 core.
At the moment I have to check until I can provide an update.

@spoonerWeb
Copy link
Contributor

spoonerWeb commented May 31, 2023

What's the status here? You won't get a new feature to v12 into the core now. 🙂

@Kephson
Copy link
Owner

Kephson commented May 31, 2023

Hey @spoonerWeb yes, you're right 🤣, I think it's now more than expected to do; pull request is welcome 😉

@cyrakoenig
Copy link

What is the current situation here? Miss paste reference for my TYPO3 12 project ;)

@Kephson
Copy link
Owner

Kephson commented Jul 3, 2023

Hi @cyrakoenig you're welcome to send a pull request, atm I didn't find any time to update it for TYPO3 12. 😮

@spoonerWeb
Copy link
Contributor

Are there any new plans? 😬

@Kephson
Copy link
Owner

Kephson commented Oct 26, 2023

Hi, there is a new branch for TYPO3 12.4 with preparations for v12, but the backend JavaScript is the hardest part and we need somebody to realize it with ES6.

@spoonerWeb
Copy link
Contributor

@Kephson Do you have someon who can handle the JS issues? I would sponsor it. Customer needs it urgently and I can't handle the JS.

@Kephson
Copy link
Owner

Kephson commented Nov 17, 2023

currently it should work with the versions "dev-main", "dev-TYPO3_12" and "dev-development".
Just do a right click and select "paste reference after" to insert a reference after current elements.

@Kephson
Copy link
Owner

Kephson commented Nov 17, 2023

there are a lot of tests needed, at the moment also the EXT: doesn't work with mulitlanguage pages.

@Shotte
Copy link

Shotte commented Dec 4, 2023

@Kephson Any progress here?

I tried "dev-main" and "dev-TYPO3_12" branches by downloding as zip installing via backend into Typo3 v12.4.8. After following your advice by "doing a right click and select "paste reference after" to insert a reference after current elements" I get this error message:
"1: The record "Reference" couldn't be saved due to disallowed value(s)."

Any ideas?

@Kephson
Copy link
Owner

Kephson commented Dec 4, 2023

Hi @Shotte I will try to follow your problems and test the integration.

@christophlehmann
Copy link

Nice Extension! Works so far in v12, but only via Context Menu. Would be a nice TYPO3 v13 core feature.

@Kephson
Copy link
Owner

Kephson commented Jan 5, 2024

Hi @christophlehmann yes, current version only via context menu, but it's 90% done in the development branch to have the "insert reference" button again; at the moment the database handling is missing to finish this functionality.
I'm working on it and then I will try to bring this to core in TYPO3 v13.

@christophlehmann
Copy link

christophlehmann commented Jan 29, 2024

I have installed EXT:container.
In a two column container element i have a header element. When i use "Paste after as reference", then the new reference is created as an "unused element" and not in the container after the header element.
Bildschirmfoto 2024-01-29 um 14 21 24

Payload paste reference after
Bildschirmfoto 2024-01-29 um 14 35 30

Payload copy after
Bildschirmfoto 2024-01-29 um 14 35 20

@saitho
Copy link

saitho commented Feb 8, 2024

Right now I get a JS error when loggin in as an editor, where top.pasteReferenceAllowed is empty, resulting in:

Uncaught SyntaxError: Unexpected token ';'

The issue lies in https://github.com/Kephson/paste_reference/blob/TYPO3_12/Classes/Hooks/PageLayoutController.php#L99, where the boolean return value from the PHP function is not processed into a boolean value for JavaScript. Casting to (int) may be sufficient, haven't checked the JS implementation yet.

@Kephson
Copy link
Owner

Kephson commented Feb 20, 2024

You could try to use the version dev-TYPO3_12 form packagist to test the problem with the JS error. Did not had the time to check this in detail.
I'm still working on a version with all old features in the dev-development version.

@ulrichmathes
Copy link

See #37 for reference preview (blue background and Edit button).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants