Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShortcutPreviewRenderer should also show time controlled references that are currently not visible #5

Closed
akiessling opened this issue Sep 14, 2022 · 1 comment

Comments

@akiessling
Copy link

Hi,

The preview renderer for shortcuts filters out time controlled references that are currently not visible. This is a bit confusing for editors, since they might think that the element does not work. Thus i'd like to remove the restrictions for StartTime and EndTime. Do you agree? Then i will prepare a pull request

--> \EHAERER\PasteReference\PageLayoutView\ShortcutPreviewRenderer::collectContentData

$queryBuilder = $this->getQueryBuilder();
$queryBuilder->getRestrictions()->removeByType(\TYPO3\CMS\Core\Database\Query\Restriction\StartTimeRestriction::class);
$queryBuilder->getRestrictions()->removeByType(\TYPO3\CMS\Core\Database\Query\Restriction\EndTimeRestriction::class);
@Kephson
Copy link
Owner

Kephson commented Oct 5, 2022

Hi @akiessling I think you're right and will integrate and test it.

Kephson pushed a commit that referenced this issue Oct 12, 2022
…rtcut preview renderer (issue #5), updated documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants