Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Change Datahandler Call when Moving Elements with Drag&Drop #6

Closed
achimfritz opened this issue Sep 16, 2022 · 0 comments · Fixed by #7
Closed

[BUG] Change Datahandler Call when Moving Elements with Drag&Drop #6

achimfritz opened this issue Sep 16, 2022 · 0 comments · Fixed by #7
Labels
bug Something isn't working

Comments

@achimfritz
Copy link

Summary / Description

do not mix data and cmd in PasteReferenceDragAndDrop JS

the PasteReferenceDragAndDrop JS uses a mix of data and cmd when moving elements like

data = [
    'tt_content' => [
        'colPos' => 10,
        'sys_language_uid' => 0
    ]
];
cmd = [
    'tt_content' => [
        1 => ['move' => 139]
    ]
];

this leads to multiple Workspace Bugs (https://forge.typo3.org/issues/92849)
core has removed this mix
https://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/c1be5540b20421fdfa295a1323b663f3189a41d7

mixing cmd and data has also dropped from EXT:container 2.0, and this leads to b13/container#297

the EXT:paste_reference datahandler call in the JS should change to:

data = null;
cmd = [
  'tt_content' => [
      1 => [
          'move' => [
              'action' => 'paste',
              'target' => 139,
              'update' => [
                  'colPos' => 10,
                  'sys_language_uid' => 0
              ]
          ]
      ]
  ]
];

i will provide an PR

@achimfritz achimfritz added the bug Something isn't working label Sep 16, 2022
@achimfritz achimfritz changed the title [BUG] Something does not work properly [BUG] Change Datahandler Call when Moving Elements with Drag&Drop Sep 16, 2022
achimfritz pushed a commit to achimfritz/paste_reference that referenced this issue Sep 16, 2022
@Kephson Kephson closed this as completed in #7 Oct 5, 2022
Kephson pushed a commit that referenced this issue Oct 12, 2022
…rtcut preview renderer (issue #5), updated documentation
mikestreety added a commit to liquidlight/paste_reference that referenced this issue Nov 18, 2022
Reimplementation of bb7b159 for TYPO3
v10

drag+drop now uses same cmd for copy/move/paste as clipboard

same has changed in core:

s. https://forge.typo3.org/issues/92849
s. https://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/c1be5540b20421fdfa295a1323b663f3189a41d7

Fixes: Kephson#6 Kephson#9

Co-Author: Achim Fritz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant