Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

props is cached in TimeRangeSlider.constructor #99

Closed
rinick opened this issue Jun 4, 2018 · 0 comments · Fixed by #100
Closed

props is cached in TimeRangeSlider.constructor #99

rinick opened this issue Jun 4, 2018 · 0 comments · Fixed by #100

Comments

@rinick
Copy link
Contributor

rinick commented Jun 4, 2018

https://github.com/uber/kepler.gl/blob/master/src/components/common/time-range-slider.js#L68

onChange is cached in constructor and nothing handle the change of the onChange handler
this make this component not reusable and might cause issue since react reuse component whenever possible

that lines in constructor() should be moved to render()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant