Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEF file fixes #50

Merged
merged 2 commits into from Feb 19, 2015
Merged

DEF file fixes #50

merged 2 commits into from Feb 19, 2015

Conversation

catharanthus
Copy link

Fixed a few problems with a DEF file that produced warning/errors:

  1. DESCRIPTION is deprecated, it was never intended for DLLs in the first place (see https://msdn.microsoft.com/en-us/library/aa984816%28v=vs.71%29.aspx, https://msdn.microsoft.com/en-us/library/k1wttw46%28v=vs.71%29.aspx)

  2. VERSION must contain either one or two numbers (https://msdn.microsoft.com/en-us/library/t9cc0ax3%28v=vs.120%29.aspx). Otherwise errors are reported by both MinGW and MSVC 2013 Community Edition.

hishamhm added a commit that referenced this pull request Feb 19, 2015
@hishamhm hishamhm merged commit 3f9f2a5 into lunarmodules:master Feb 19, 2015
@hishamhm
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants