Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: validate and integrate elastic-search applications with V2 #1031

Open
1 task done
Sarthak160 opened this issue Oct 19, 2023 · 5 comments
Open
1 task done

Comments

@Sarthak160
Copy link
Member

Is there an existing feature request for this?

  • I have searched the existing issues

Summary

Since V2 is completely language agnostic and uses ebpf based approach to instrument traffic. We should try by verifying it with different dependencies. And as ElasticSearch internally uses HTTP protocol for internal communication we should already support the mocking feature for outgoing HTTP calls (client) .
But still we should add a POC in the form of sample app as we have already done in V1 -https://github.com/keploy/samples-go/tree/v1/gin-elastic

Why should this be worked on?

This can be useful for users who want to mock real ElasticDB for testing purposes . They can leverage this feature of keploy to improve their testing-mocking experience .

Repository

keploy

@anshjain16
Copy link

Hey @Sarthak160 can i start working on this.
and can you please elaborate the issue more..

@Sarthak160
Copy link
Member Author

Hi @anshjain16 , Basically you have to integrate keploy with any go application using elastic search you can refer this as well and have to see If Tescases and mocks are being captured . Also you have to run those tescases in Test mode to see if its a successful test result .
Technically since we have integration for Http outgoing , so we should support elastic search as well . But still some strong POC would help to verify .
So If you are using mentioned sample app you have to remove the keploy-sdk integration which we have to so earlier in V1 .
You can refer other samples such as Gin Mongo for reference that how you can make it compatible with Keploy V2

@kanugurajesh
Copy link

Hi @Sarthak160 can i work on this issue ?

@anshjain16
Copy link

Hey @Sarthak160 where should i create my pull request and what else should i include with it along with the sample app source code

@Sarthak160
Copy link
Member Author

@anshjain16 , You can create PR on the corresponding samples repository , you have created for POC . Like if you created your API in go you have to make PR in samples go !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants