Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: keploy-config throwing error when containerName is not provided. #1161

Closed
1 task done
charankamarapu opened this issue Dec 1, 2023 · 0 comments · Fixed by #1164
Closed
1 task done

[bug]: keploy-config throwing error when containerName is not provided. #1161

charankamarapu opened this issue Dec 1, 2023 · 0 comments · Fixed by #1164
Assignees
Labels
bug Something isn't working keploy

Comments

@charankamarapu
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

  1. Currently When I use keploy with docker and keploy-config. When I don't provide containerName param in the config but provide it in the appCmd it shouldn't throw an error but it is throwing an error.
Screenshot 2023-12-01 at 3 20 43 PM

This is happening because in cmd/record.go we are checking for containerName but only in args not in config. We need to actually check it in appCmd and not in os.args.

Steps to reproduce

  1. Run gin-mongo via docker and use keploy-config.

Environment

None

Version

Local

Repository

keploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keploy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants