Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: check for mock kind in parsers #1901

Closed
1 task done
shivamsouravjha opened this issue May 27, 2024 · 7 comments
Closed
1 task done

[bug]: check for mock kind in parsers #1901

shivamsouravjha opened this issue May 27, 2024 · 7 comments
Labels
bug Something isn't working Go Pull requests that update Go code Good First Issue Good for newcomers keploy

Comments

@shivamsouravjha
Copy link
Contributor

shivamsouravjha commented May 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

  • Incase of filtered and unfiltered mocks, the fetched mocks from mockdb should also be filtered on kind inorder to avoid extra mocks during matching
  • Happens in Generic,mongo and mysql parsers

Steps to reproduce

  • search for kind in decodeor match
  • better to implement in decode of files.

Environment

None

Version

Cloud

Repository

keploy

@shivamsouravjha shivamsouravjha added the bug Something isn't working label May 27, 2024
@shivamsouravjha shivamsouravjha added Good First Issue Good for newcomers Go Pull requests that update Go code labels May 27, 2024
@anshjain16
Copy link

Hey @shivamsouravjha can i work on this issue

@shivamsouravjha
Copy link
Contributor Author

sure @anshjain16 you can work on this

@anshjain16
Copy link

@shivamsouravjha can you please provide some more details about this issue

@anshjain16
Copy link

image
should the mocks that are being fetched should again be filtered on the basis of kind of mock

@shivamsouravjha
Copy link
Contributor Author

yes @anshjain16 the mocks fetched from filtered and unfiltered mockdb functions are to be filtered again in the parsers.

@anshjain16
Copy link

is it solved?

@shivamsouravjha
Copy link
Contributor Author

yes @anshjain16 the changes fixed the issue, you can look out for other open issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Go Pull requests that update Go code Good First Issue Good for newcomers keploy
Projects
None yet
Development

No branches or pull requests

2 participants