Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: do not log any error while reading from client if app is closed. #1902

Open
1 task done
gouravkrosx opened this issue May 27, 2024 · 0 comments
Open
1 task done
Labels
bug Something isn't working dev-fellowship Valid Issues that will be considered for Fellowship Performance evaluation keploy level-2 Minor bugs or issues (4 points)

Comments

@gouravkrosx
Copy link
Member

gouravkrosx commented May 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

  • We don't how know the user application is written, there can be some cases where some connections do not get closed after the termination of the application.
  • In such cases, keploy proxy can also get errors eg: EOF, connection reset by peer, etc. We should not log these errors.
  • Right now, only EOF is handled if the app is closed gracefully, for other cases, keploy proxy should be aware of the application status.

Steps to reproduce

  1. Record some test cases and mocks for your application.
  2. During test mode, abruptly close the application by sending SIGKILL or SIGTERM to the app PGID.
  3. You will see errors.

Environment

None

Version

Local

Repository

keploy

@gouravkrosx gouravkrosx added the bug Something isn't working label May 27, 2024
@Swpn0neel Swpn0neel added dev-fellowship Valid Issues that will be considered for Fellowship Performance evaluation level-2 Minor bugs or issues (4 points) labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev-fellowship Valid Issues that will be considered for Fellowship Performance evaluation keploy level-2 Minor bugs or issues (4 points)
Projects
None yet
Development

No branches or pull requests

2 participants