Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: add a filter for request header fields #395

Closed
1 task done
re-Tick opened this issue Feb 23, 2023 · 8 comments · May be fixed by keploy/typescript-sdk#47
Closed
1 task done

[feature]: add a filter for request header fields #395

re-Tick opened this issue Feb 23, 2023 · 8 comments · May be fixed by keploy/typescript-sdk#47
Assignees
Labels
Good First Issue Good for newcomers Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository

Comments

@re-Tick
Copy link
Contributor

re-Tick commented Feb 23, 2023

Is there an existing feature request for this?

  • I have searched the existing issues

Summary

Currently, when an API request is captured then its authorisation headers are also captured which could be private for users.
There should be a way to remove these specified key-value pair from the request-response headers. Recently changes have been made for this in keploy server and go-sdk. In PostTC gRPC call there is a Remove string array which is used to filter the request-response header

Why should this be worked on?

Since the header fields can contain user specific data so there must be a way to filter them.

@re-Tick re-Tick added the Good First Issue Good for newcomers label Feb 23, 2023
@re-Tick
Copy link
Contributor Author

re-Tick commented Feb 23, 2023

We can take references from go-sdk changes in this PR

@shreyanshshah27
Copy link

Hey @re-Tick

I would like to work on this feature. Can you please assign this to me?

shreyanshshah27 referenced this issue in shreyanshshah27/typescript-sdk Feb 23, 2023
shreyanshshah27 referenced this issue in shreyanshshah27/typescript-sdk Feb 23, 2023
Signed-off-by: Shreyansh Shah <shreyansh_shah@yahoo.com>
shreyanshshah27 referenced this issue in shreyanshshah27/typescript-sdk Feb 23, 2023
Signed-off-by: Shreyansh Shah <shreyansh_shah@yahoo.com>
shreyanshshah27 referenced this issue in shreyanshshah27/typescript-sdk Feb 23, 2023
@re-Tick
Copy link
Contributor Author

re-Tick commented Feb 23, 2023

Hi @shreyanshshah27, great feel free to discuss these changes.

shreyanshshah27 referenced this issue in shreyanshshah27/typescript-sdk Feb 23, 2023
Signed-off-by: Shreyansh Shah <shreyansh_shah@yahoo.com>
@shreyanshshah27
Copy link

Hey @re-Tick

Sorry for the bit of a spam.

I've created a PR for this. Requesting you to have a look at it and let me know your thoughts.

@re-Tick
Copy link
Contributor Author

re-Tick commented Feb 24, 2023

Hey @shreyanshshah27, please add this fields for the mock module also. And try them on your local device by excluding and replcaing some fields.

@shreyanshshah27
Copy link

Hey @re-Tick

I've already done that testing with the mock module on my local machine but I'll add these field in the mock module.

@re-Tick
Copy link
Contributor Author

re-Tick commented Feb 24, 2023

Great, Please make PR for this changes and mention this issue in the PR.

@Sonichigo Sonichigo transferred this issue from keploy/typescript-sdk Mar 3, 2023
@Sonichigo Sonichigo added the Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository label Mar 3, 2023
@charankamarapu
Copy link
Member

This has been taken care in keploy v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants