-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: add a filter for request header fields #395
Comments
We can take references from go-sdk changes in this PR |
Hey @re-Tick I would like to work on this feature. Can you please assign this to me? |
Signed-off-by: Shreyansh Shah <shreyansh_shah@yahoo.com>
Signed-off-by: Shreyansh Shah <shreyansh_shah@yahoo.com>
Hi @shreyanshshah27, great feel free to discuss these changes. |
Signed-off-by: Shreyansh Shah <shreyansh_shah@yahoo.com>
Hey @re-Tick Sorry for the bit of a spam. I've created a PR for this. Requesting you to have a look at it and let me know your thoughts. |
Hey @shreyanshshah27, please add this fields for the mock module also. And try them on your local device by excluding and replcaing some fields. |
Hey @re-Tick I've already done that testing with the mock module on my local machine but I'll add these field in the mock module. |
Great, Please make PR for this changes and mention this issue in the PR. |
This has been taken care in keploy v2. |
Is there an existing feature request for this?
Summary
Currently, when an API request is captured then its authorisation headers are also captured which could be private for users.
There should be a way to remove these specified key-value pair from the request-response headers. Recently changes have been made for this in keploy server and go-sdk. In PostTC gRPC call there is a Remove string array which is used to filter the request-response header
Why should this be worked on?
Since the header fields can contain user specific data so there must be a way to filter them.
The text was updated successfully, but these errors were encountered: