Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: need to log the keploy mode #390

Closed
1 task done
re-Tick opened this issue Feb 23, 2023 · 7 comments · May be fixed by keploy/typescript-sdk#48 or keploy/typescript-sdk#75
Closed
1 task done

[feature]: need to log the keploy mode #390

re-Tick opened this issue Feb 23, 2023 · 7 comments · May be fixed by keploy/typescript-sdk#48 or keploy/typescript-sdk#75
Assignees
@partik03
Labels
Good First Issue Good for newcomers Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository

Comments

@re-Tick
Copy link
Contributor

re-Tick commented Feb 23, 2023

Is there an existing feature request for this?

  • I have searched the existing issues

Summary

Currently, the keploy mode variable is not logged. It can help notify users when keploy is recording, testing, or off and also brief them about the behavior of that mode.

Why should this be worked on?

This became a need because users where incorrectly setting the mode variable and it became difficult to actually understand if keploy was initialized to the right mode. These logs will help understand more about keploy.
@re-Tick re-Tick added the Good First Issue Good for newcomers label Feb 23, 2023
@partik03
Copy link

Hey @re-Tick I wanted to take up this one can you assign it to me

@re-Tick
Copy link
Contributor Author

re-Tick commented Feb 24, 2023

Hi @partik03, I am assigning this issue to you. Please feel free to discuss the changes here

Hermione2408 referenced this issue in Hermione2408/typescript-sdk Feb 25, 2023
@Hermione2408
feat(mock.ts, keploy.ts, client.ts): adding Keploy Mode in logs to no…
195303f 
…tify user

Adding Keploy mode in logs to notify user in which mode keploy is running whether it is record,
test, off

feat #45
@Hermione2408 Hermione2408 mentioned this issue Feb 25, 2023
Open
@Hermione2408
Copy link
Member

@re-Tick Sorry I started working on it when you suggested it to me. I have created a PR for the same. Next time I'll make sure to get the issue assigned before starting to work on it.

Hermione2408 referenced this issue in Hermione2408/typescript-sdk Mar 1, 2023
@Hermione2408
feat(keploy.ts, mock.ts): adding log in Keploy.ts and mock.ts
0085783 
feat #45
Hermione2408 referenced this issue in Hermione2408/typescript-sdk Mar 1, 2023
@Hermione2408
feat(mock.ts, keploy.ts, client.ts): adding Keploy Mode in logs to no…
838dcb1 
…tify user

Adding Keploy mode in logs to notify user in which mode keploy is running whether it is record,
test, off

feat #45

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Hermione2408 referenced this issue in Hermione2408/typescript-sdk Mar 1, 2023
@Hermione2408
feat(keploy.ts, mock.ts): adding log in Keploy.ts and mock.ts
1278a4f 
feat #45

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Hermione2408 referenced this issue in Hermione2408/typescript-sdk Mar 2, 2023
@Hermione2408
feat: changing log position in mock.ts
e8a3620 
feat #45
Hermione2408 referenced this issue in Hermione2408/typescript-sdk Mar 2, 2023
@Hermione2408
feat(mock.ts, keploy.ts, client.ts): adding Keploy Mode in logs to no…
deded77 
…tify user

Adding Keploy mode in logs to notify user in which mode keploy is running whether it is record,
test, off

feat #45

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Hermione2408 referenced this issue in Hermione2408/typescript-sdk Mar 2, 2023
@Hermione2408
feat(keploy.ts, mock.ts): adding log in Keploy.ts and mock.ts
9b70a76 
feat #45

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Hermione2408 referenced this issue in Hermione2408/typescript-sdk Mar 2, 2023
@Hermione2408
feat: changing log position in mock.ts
1ad2d59 
feat #45

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
@Sonichigo Sonichigo transferred this issue from keploy/typescript-sdk Mar 3, 2023
@Sonichigo Sonichigo added the Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository label Mar 3, 2023
@tanmay-bajaj tanmay-bajaj mentioned this issue Mar 24, 2023
Open
@VishalMyla
Copy link

@re-Tick Please review the PR #390

@ashwintelmore
Copy link

should i work on this issue

@re-Tick
Copy link
Contributor Author

re-Tick commented Jul 17, 2023

Hi @ashwintelmore, people have contributed for this issue. As we have discussed here

@charankamarapu
Copy link
Member

This issue has been taken care in keploy v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@partik03 partik03

Labels
Good First Issue Good for newcomers Repo/@typescript-sdk Issue Related to Keploy TS-SDK Repository
Projects
None yet
Milestone
No milestone
7 participants
@Sonichigo @re-Tick @ashwintelmore @charankamarapu @Hermione2408 @VishalMyla @partik03