Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart of locust service includes service account for granting cluster admin access #23

Open
didiladi opened this issue Apr 21, 2021 · 0 comments · May be fixed by #24
Open

Helm chart of locust service includes service account for granting cluster admin access #23

didiladi opened this issue Apr 21, 2021 · 0 comments · May be fixed by #24
Assignees
@didiladi

Comments

@didiladi
Copy link

The helm chart in the repository includes a ClusterRoleBinding and ServiceAccount for granting cluster admin access to the locust service.

However, the cluster admin access is not needed by the locust service, since it just executes locust without any need to access any resources within the kubernetes cluster.

I just tested it on our execution plane - running the locust service without the ClusterRoleBinding and ServiceAccount works like a charm. So, the whole file helm/templates/serviceaccount.yaml can be removed.
didiladi added a commit to didiladi/locust-service that referenced this issue Apr 21, 2021
@didiladi
fix: Remove cluster admin ClusterRoleBinding and ServiceAccount
b841482 
This commit removes the `ClusterRoleBinding` and `ServiceAccount` from
the helm chart. The cluster admin access is not needed by the locust
service, since it just executes locust without any need to access any
resources within the kubernetes cluster.

fixes keptn-sandbox#23
@didiladi didiladi linked a pull request Apr 21, 2021 that will close this issue
Open
didiladi added a commit to didiladi/locust-service that referenced this issue Apr 21, 2021
@didiladi
fix: Remove cluster admin ClusterRoleBinding and ServiceAccount
36b74df 
This commit removes the `ClusterRoleBinding` and `ServiceAccount` from
the helm chart. The cluster admin access is not needed by the locust
service, since it just executes locust without any need to access any
resources within the kubernetes cluster.

fixes keptn-sandbox#23

Signed-off-by: Dieter Ladenhauf <dieter.ladenhauf@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@didiladi didiladi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove cluster admin ClusterRoleBinding and ServiceAccount didiladi/locust-service
1 participant
@didiladi