Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final fit not replacing the model in training history #249

Closed
twprinston opened this issue Oct 9, 2018 · 2 comments · Fixed by #268
Closed

Final fit not replacing the model in training history #249

twprinston opened this issue Oct 9, 2018 · 2 comments · Fixed by #268
Assignees

Comments

@twprinston
Copy link

Hi,

if I run clf.final_fit(x_train, y_train, x_test, y_test, retrain=True)
then call
model = clf.load_searcher().load_best_model().produce_keras_model()
Is this model the retrained model?

I traced the 0.2.18 ImageSupervised.final_fit() source code but I'm not sure it's true.
load_best_model() seems to return the original best model in searching phase.

Thank you.

@haifeng-jin
Copy link
Member

This might be a bug. I will investigate it. @twprinston Thanks.

@haifeng-jin haifeng-jin self-assigned this Oct 11, 2018
@haifeng-jin haifeng-jin changed the title How can I get the final_fit retrained model? Final fit not replacing the model in training history Oct 11, 2018
@kavehtp
Copy link

kavehtp commented Oct 14, 2018

Faced a similar problem:

After training the model using clf.fit() function, calling clf.final_fit() does not make any difference. The best model remains the same and does not get updated. So:

clf = ak.ImageClassifier(verbose=True, resume=True, path='autokeras-run')	
clf.final_fit(x_train, y_train, x_dev, y_dev, retrain=True)
y_test_pred = clf.predict(x_test)

leads to exactly the same results as:

clf = ak.ImageClassifier(verbose=True, resume=True, path='autokeras-run')
y_test_pred = clf.predict(x_test)

@haifeng-jin haifeng-jin added this to To do in Auto-Keras 0.3 via automation Oct 19, 2018
@haifeng-jin haifeng-jin moved this from To do to In progress in Auto-Keras 0.3 Oct 19, 2018
Auto-Keras 0.3 automation moved this from In progress to Done Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants