Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keras.io lacks an easy way to take ownership of an issue (e.g. contributing an example) #103

Closed
joshuacwnewton opened this issue Jun 18, 2020 · 2 comments

Comments

@joshuacwnewton
Copy link

joshuacwnewton commented Jun 18, 2020

Issue

Requests for code examples are currently managed by call_for_contributions.md. This makes it difficult to indicate when someone is currently working on a contribution, and may result in conflicts.

Issue #102 is also a good example of the need for a fix.

Proposed solution

It might be helpful to instead create GitHub issues for each of the requested examples. (Possibly with a unique tag to distinguish them from other issues, which could then be referred to using a link in the Keras.io documentation.) That way, people can comment/assign themselves to indicate that they've started working on an example. This would also allow for discussion about implementation details prior to a PR.

Thanks!

@fchollet
Copy link
Member

fchollet commented Jun 23, 2020

It might be helpful to instead create GitHub issues for each of the requested examples. (Possibly with a unique tag to distinguish them from other issues, which could then be referred to using a link in the Keras.io documentation.) That way, people can comment/assign themselves to indicate that they've started working on an example. This would also allow for discussion about implementation details prior to a PR.

I would suggest submitting PRs to call_for_contributions.md to add information such as: an example is currently being worked on, who is working on it, a link to GitHub issue tracking discussions and progress, etc.

People working on an example can create GitHub issues to track their work, but that is optional.

@joshuacwnewton
Copy link
Author

Thanks for the clarification. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants