add: an example on pointnet model for segmentation #676

sayakpaul · 2021-10-23T06:38:39Z

Ccing @soumik12345 who is the primary author of this example.

A Colab Notebook is available here for verification: https://colab.research.google.com/drive/1-_pB22ZIbYJM95JH-vkXzXlZ1mhsx9pB?usp=sharing.

google-cla · 2021-10-23T07:57:04Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

soumik12345 · 2021-10-23T07:59:12Z

@googlebot I fixed it.

google-cla · 2021-10-23T07:59:16Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

sayakpaul · 2021-10-23T08:01:42Z

examples/vision/pointnet_segmentation.py

+def sample_point_cloud(point_cloud, n_sample_points: int):
+    n_points = len(point_cloud)
+    sampled_indices = random.sample(list(range(n_points)), n_sample_points)
+    sampled_point_cloud = np.array([point_cloud[i] for i in sampled_indices])
+    return sampled_point_cloud


@soumik12345 seems like this code block is not being used?

sayakpaul · 2021-10-23T08:02:44Z

examples/vision/pointnet_segmentation.py

+print(f"Validation prediction shape: {val_predictions.shape}")
+
+
+def visualize_single_point_cloud(point_clouds, label_cloudss, idx):


label_cloudss -> label_clouds

sayakpaul · 2021-10-23T08:03:37Z

examples/vision/pointnet_segmentation.py

+idx = np.random.choice(len(validation_batch[0]))
+print(f"Index selected: {idx}")
+visualize_single_point_cloud(validation_batch[0], val_predictions, idx)


@soumik12345 I think it might make sense to also plot the same thing with the actual labels so that the readers can notice a comparison.

google-cla · 2021-10-23T08:06:18Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

sayakpaul · 2021-10-23T08:06:46Z

@googlebot I fixed it.

google-cla · 2021-10-23T08:06:50Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-10-23T08:09:06Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

soumik12345 · 2021-10-23T08:17:05Z

@googlebot I fixed it.

google-cla · 2021-10-23T08:17:09Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

fchollet

Thanks for the PR!

examples/vision/pointnet_segmentation.py

google-cla · 2021-10-24T04:24:52Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

sayakpaul · 2021-10-24T04:25:03Z

@fchollet addressed your comments.

google-cla · 2021-10-24T10:40:24Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-10-24T20:28:53Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

fchollet

Great stuff! The code looks good to me. I just pushed some copyedits. Everything looks ready.

google-cla · 2021-10-25T01:42:38Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

sayakpaul · 2021-10-25T01:43:06Z

@fchollet thank you for your reviews. Done adding the files.

Over to you.

soumik12345 · 2021-10-25T18:09:46Z

@googlebot I fixed it.

google-cla · 2021-10-25T18:09:55Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

fchollet · 2021-10-26T23:52:35Z

@soumik12345 @sayakpaul thanks for the very nice contribution!

add: an example on pointnet model for segmentation

069c4e9

google-cla bot added the cla: yes label Oct 23, 2021

Inference bug fix

893c9c3

google-cla bot added cla: no and removed cla: yes labels Oct 23, 2021

sayakpaul commented Oct 23, 2021

View reviewed changes

Removed unused function

9d0fcf8

Updated example

e996590

fchollet reviewed Oct 23, 2021

View reviewed changes

addressed feedback

f50685b

add: a note on our repository

2bcdc20

Copyedits

6504f91

fchollet reviewed Oct 24, 2021

View reviewed changes

add: generated files

e69052e

fchollet merged commit 8160ea4 into keras-team:master Oct 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add: an example on pointnet model for segmentation #676

add: an example on pointnet model for segmentation #676

sayakpaul commented Oct 23, 2021 •

edited

google-cla bot commented Oct 23, 2021

soumik12345 commented Oct 23, 2021

google-cla bot commented Oct 23, 2021

sayakpaul Oct 23, 2021

soumik12345 Oct 23, 2021

sayakpaul Oct 23, 2021

soumik12345 Oct 23, 2021

sayakpaul Oct 23, 2021

soumik12345 Oct 23, 2021

google-cla bot commented Oct 23, 2021

sayakpaul commented Oct 23, 2021

google-cla bot commented Oct 23, 2021

google-cla bot commented Oct 23, 2021

soumik12345 commented Oct 23, 2021

google-cla bot commented Oct 23, 2021

fchollet left a comment

google-cla bot commented Oct 24, 2021

sayakpaul commented Oct 24, 2021

google-cla bot commented Oct 24, 2021

google-cla bot commented Oct 24, 2021

fchollet left a comment

google-cla bot commented Oct 25, 2021

sayakpaul commented Oct 25, 2021

soumik12345 commented Oct 25, 2021

google-cla bot commented Oct 25, 2021

fchollet commented Oct 26, 2021

		print(f"Validation prediction shape: {val_predictions.shape}")


		def visualize_single_point_cloud(point_clouds, label_cloudss, idx):

add: an example on pointnet model for segmentation #676

add: an example on pointnet model for segmentation #676

Conversation

sayakpaul commented Oct 23, 2021 • edited

google-cla bot commented Oct 23, 2021

soumik12345 commented Oct 23, 2021

google-cla bot commented Oct 23, 2021

sayakpaul Oct 23, 2021

Choose a reason for hiding this comment

soumik12345 Oct 23, 2021

Choose a reason for hiding this comment

sayakpaul Oct 23, 2021

Choose a reason for hiding this comment

soumik12345 Oct 23, 2021

Choose a reason for hiding this comment

sayakpaul Oct 23, 2021

Choose a reason for hiding this comment

soumik12345 Oct 23, 2021

Choose a reason for hiding this comment

google-cla bot commented Oct 23, 2021

sayakpaul commented Oct 23, 2021

google-cla bot commented Oct 23, 2021

google-cla bot commented Oct 23, 2021

soumik12345 commented Oct 23, 2021

google-cla bot commented Oct 23, 2021

fchollet left a comment

Choose a reason for hiding this comment

google-cla bot commented Oct 24, 2021

sayakpaul commented Oct 24, 2021

google-cla bot commented Oct 24, 2021

google-cla bot commented Oct 24, 2021

fchollet left a comment

Choose a reason for hiding this comment

google-cla bot commented Oct 25, 2021

sayakpaul commented Oct 25, 2021

soumik12345 commented Oct 25, 2021

google-cla bot commented Oct 25, 2021

fchollet commented Oct 26, 2021

sayakpaul commented Oct 23, 2021 •

edited