Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo on documentation? #9821

Closed
Scoodood opened this issue Apr 2, 2018 · 5 comments
Closed

Typo on documentation? #9821

Scoodood opened this issue Apr 2, 2018 · 5 comments

Comments

@Scoodood
Copy link

Scoodood commented Apr 2, 2018

The documentation of keras.backend.gradients(loss, variables) said

Returns the gradients of variables w.r.t. loss.

But I think it should be

Returns the gradients of loss w.r.t. variables
right?
@gabrieldemarmiesse
Copy link
Contributor

Seems reasonable, can you do a PR for this?

@Scoodood
Copy link
Author

Scoodood commented Apr 4, 2018

I tried to fork this repo to my account so that I can create a new branch, make changes and the do pull request. But the forking process seems to stuck forever... any idea how to fix it? Any better way to do PR?

screen shot 2018-04-04 at 12 38 41 am

@gabrieldemarmiesse
Copy link
Contributor

wow, that's some bad luck right there. I'll do this PR when I have the time then, since it's not urgent. Thanks for reporting it!

@gabrieldemarmiesse gabrieldemarmiesse mentioned this issue Apr 6, 2018
Merged
@tiferet
Copy link
Contributor

tiferet commented Oct 15, 2019

Looks like this issue should be closed, by PR #9866.

@gabrieldemarmiesse
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gabrieldemarmiesse @tiferet @Scoodood