New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libc++ (fixes #6) #10
base: master
Are you sure you want to change the base?
Conversation
Awesome! |
Add libc++-svn to the PKGBUILD, adapting some lines from the libc++ PKGBUILD, to be found at https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=libc%2B%2B.
An incorrect path slipped through
@hesiod Thank you very much for the pull request. I know libc++ is important for some people, but unfortunately I've never been able to invest more time in acquainting myself better with it. Here are some points that we'll probably need to take care of (starting from the least important ones):
My biggest concern so far are the instructions suggesting that Clang is the preferred compiler. I wonder if we shouldn't indeed make the additional effort to use it instead of GCC. The obvious problem is which Clang should we use. There are several possible approaches (unless I'm missing something of course):
Being a perfectionist, I'm leaning towards the last variant, but again, it might require some non-trivial effort, and so it might be better to leave it as a todo. I'll need to do more testing with different setups, but so far my feelings are that we should avoid GCC if possible and pulling Clang might be the most balanced short-term approach. And we definitely need to have all unit tests passing, or at least know why they fail and that it's not a serious concern (like what's happening with those AMDGPU tests in #12). Once again, really appreciate your help and will be glad to hear your opinion. Addendum: the unit tests that fail. When built with Clang
When built with GCC
|
So far we've simply installed the LICENSE.TXT file located in the LLVM root as the sole license file. However, as seen in #10, there are other license files too. In fact, there are also license files in some of the subdirectories, which is also indicated in the LICENSE.TXT itself. The new `_install_licenses()` tries to be a tiny bit smart about the issue by `find`-ing all appropriate license files. Please note that the new function does require a path as an argument.
So far we've simply installed the LICENSE.TXT file located in the LLVM root as the sole license file. However, as seen in #10, there are other license files too. In fact, there are also license files in some of the subdirectories, which is also indicated in the LICENSE.TXT itself. The new `_install_licenses()` tries to be a tiny bit smart about the issue by `find`-ing all appropriate license files. Please note that the new function does require a path as an argument.
I've updated the patch, but the web editor produced a merged commit that'll probably make the history a bit hard to follow. I'll look into this again when we decide to merge back to master: might simply cherry-pick or custom rebase the needed commits, a bit like I did with #9. Let's keep it the way it is for reference for now. |
Add libc++-svn to the PKGBUILD, adapting some lines from the libc++ PKGBUILD,
to be found at https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=libc%2B%2B.
I still have to test this a bit more, but it should generally work.