Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid coordinates on release #148

Closed
DerDakon opened this issue Mar 27, 2019 · 4 comments
Closed

invalid coordinates on release #148

DerDakon opened this issue Mar 27, 2019 · 4 comments

Comments

@DerDakon
Copy link
Contributor

DerDakon commented Mar 27, 2019

The linear plugin will set the coordinates of a release event to 0, 0. Afterwards the calibration will be applied to it, so these coordinates become "random" (from a users perspective). For me it usually was something like -11, -9. This breaks e.g. the missing coordinates detection in Qt in all versions up to 5.12.2 fix in review. Maybe the calibration should be guarded by something like this:

if (pressure != 0 || samp->x != 0 || samp->y !=0)
@merge
Copy link
Member

merge commented Mar 27, 2019

what tslib modules do you use, i.e. how does your ts.conf file look like?

thanks for reporting this. maybe we shouldn't have zeros in a release event...

@DerDakon
Copy link
Contributor Author

module_raw input
module linear

Looks like it is the other plugin that set the coordinates to 0 and then linear breaks it, but anyway.

@merge
Copy link
Member

merge commented Mar 28, 2019

while I think about it I guess the fix in Qt in ok. This should only apply to the the legacy interface that Qt is using. If pressure is 0, you shouldn't evaluate the x/y coordinates there.

It's about time to implement ts_read_mt() in qtslib... (#ifdef TSLIB_VERSION_MT).

@merge
Copy link
Member

merge commented Apr 24, 2019

again, thanks for reporting this. seems to be fixed in Qt.

@merge merge closed this as completed Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants