Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better selection step #13

Closed
kermitt2 opened this issue Jan 7, 2019 · 5 comments
Closed

Better selection step #13

kermitt2 opened this issue Jan 7, 2019 · 5 comments
Assignees

Comments

@kermitt2
Copy link
Owner

kermitt2 commented Jan 7, 2019

Currently (it's an early version!), we simply use the first best result of the search step as camdidate for a matching. Obviously, we should consider the top n best candidate, and select the best one based on the parsed metadata (these parsed metadata can come as additional arguments of the query, see #12 or after a parsing of the reference string with GROBID citation model).

The matching service would then look much more like a traditional record matching service with a blocking step (search-based) and a fine-grained matching step where metadata are considered to select the best candidate in the block.

@kermitt2
Copy link
Owner Author

kermitt2 commented Feb 15, 2019

Example:

  • Pnueli L, Carmel-Goren L, Hareven D, Gutfinger T,Alvarez J, Ganal M, Zamir D, Lifschitz E. Development.1998;125(11):1979–1989.

http://localhost:8080/service/lookup?biblio=Pnueli%20L,%20Carmel-Goren%20L,%20Hareven%20D,%20Gutfinger%20T,Alvarez%20J,%20Ganal%20M,%20Zamir%20D,%20Lifschitz%20E.%20Development.1998%3B125(11)%3A1979%E2%80%931989.&firstAuthor=Pnueli
-> no result
(wrong selection 10.1007/bf00022524)

good selection ->
10.1242/dev.125.11.1979
https://api.crossref.org/v1/works/10.1242/dev.125.11.1979

but not in the index?

@kermitt2
Copy link
Owner Author

Example:

  • Adachi, A., Gendelman, H.E., Koenig, S., Folks, T., Willey, R., Rabson, A., andMartin, M.A. (1986). Production of acquired immunodeficiency syndrome-associated retrovirus in human and nonhuman cells transfected with an infec-tious molecular clone. J. Virol.59, 284–291.

http://localhost:8080/service/lookup?biblio=Adachi,%20A.,%20Gendelman,%20H.E.,%20Koenig,%20S.,%20Folks,%20T.,%20Willey,%20R.,%20Rabson,%20A.,%20andMartin,%20M.A.%20(1986).%20Production%20of%20acquired%20immunodeficiency%20syndrome-associated%20retrovirus%20in%20human%20and%20nonhuman%20cells%20transfected%20with%20an%20infec-tious%20molecular%20clone.%20J.%20Virol.59,%20284%E2%80%93291.&postValidate=false
-> no result
(wrong selection 10.1073/pnas.82.13.4539)

@kermitt2
Copy link
Owner Author

kermitt2 commented Sep 5, 2021

Implemented with PR #62 but we still use only article title and first author for the pairwise ranking for the moment :)

@kermitt2
Copy link
Owner Author

Second example works fine with new version, selection and matching provide the right entry.

But the DOI of the first example, for some reasons, is not present in the latest index and can't be selected. To be investigated :/

@kermitt2
Copy link
Owner Author

Both examples are working fine now with version 0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant