Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CONDA_PREFIX when training DeLFT #490

Open
de-code opened this issue Aug 23, 2019 · 1 comment
Open

Add support for CONDA_PREFIX when training DeLFT #490

de-code opened this issue Aug 23, 2019 · 1 comment

Comments

@de-code
Copy link
Collaborator

de-code commented Aug 23, 2019

Based on the GitHub conversation:

I wonder if we could read the CONDA_PREFIX and pick up python from that location instead of just calling a generic python3 executable...

In this way we maintain the double compatibility:

  1. environment activation + command launch and
  2. environment setting + command launch

/cc @lfoppiano

@de-code
Copy link
Collaborator Author

de-code commented Aug 23, 2019

Descripton for CONDA_PREFIX from the docs:

The path to the conda environment used to build the package, such as /path/to/conda/env. Useful to pass as the environment prefix parameter to various conda tools, usually labeled -p or --prefix.

I thought CONDA_PREFIX was set after a conda environment was activated. But it seems it is also set by users to specify which environment they want to use.

The regular Python's equivalent is VIRTUAL_ENV to some degree. I didn't find much documentation for it. I don't think people set it to indicate which virtual environment to use. Instead it will be passed in. There wouldn't be much harm in using it though. As that should be the same after activating the environment.

We could use PythonEnvironmentConfig.java - or only support CONDA_PREFIX for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant