Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of __all__ from all modules #33

Closed
spbnick opened this issue Mar 23, 2021 · 3 comments
Closed

Remove use of __all__ from all modules #33

spbnick opened this issue Mar 23, 2021 · 3 comments
Assignees
@effulgentstar
Labels
good first issue Good for newcomers

Comments

@spbnick
Copy link
Collaborator

spbnick commented Mar 23, 2021 •
edited

Some of the kcidb-io modules use __all__, mostly (if not completely) to avoid warnings from pylint about unused symbols.
The use of __all__ in kcidb-io modules, and in general, makes little sense, as wildcard imports are not really done normally. So, remove them to avoid stale/useless code and its maintenance, and find some other way to please pylint.
@spbnick spbnick added the good first issue Good for newcomers label Mar 23, 2021
@effulgentstar
Copy link
Contributor

effulgentstar commented Oct 19, 2021 •
edited

@spbnick can I work on this?

@spbnick
Copy link
Collaborator Author

spbnick commented Oct 19, 2021

@effulgentstar, absolutely! Thanks for taking it on :)

@effulgentstar effulgentstar self-assigned this Oct 20, 2021
@effulgentstar effulgentstar mentioned this issue Oct 22, 2021
Merged
@spbnick
Copy link
Collaborator Author

spbnick commented Oct 22, 2021

Fixed by #36.

@spbnick spbnick closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@effulgentstar effulgentstar

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spbnick @effulgentstar