Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units for timings in tests #28

Closed
egpbos opened this issue Nov 13, 2017 · 2 comments
Closed

Units for timings in tests #28

egpbos opened this issue Nov 13, 2017 · 2 comments
Assignees
@egpbos
Labels
user-friendliness
Projects
Team Project

Comments

@egpbos
Copy link
Contributor

egpbos commented Nov 13, 2017

The reported times in the tests don't give the units (s? ms? ns?), nor the type of time (wall clock, cpu/gpu).
@isazi
Copy link
Collaborator

isazi commented Nov 13, 2017

Time seems to be reported in milliseconds for both CUDA and OpenCL. Maybe adding the unit when printing the results?

@benvanwerkhoven benvanwerkhoven added this to To do in Team Project Nov 14, 2017
@egpbos egpbos self-assigned this Nov 15, 2017
@egpbos egpbos mentioned this issue Nov 15, 2017
Merged
@egpbos
Copy link
Contributor Author

egpbos commented Nov 15, 2017

Implemented this in #56

@egpbos egpbos moved this from To do to Ready to merge in Team Project Nov 15, 2017
Team Project automation moved this from Ready to merge to Done Nov 15, 2017
benvanwerkhoven added a commit that referenced this issue Nov 15, 2017
@benvanwerkhoven
fix failing tests after the printing of units, issue #28
6bb698d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egpbos egpbos

Labels
user-friendliness
Projects
No open projects
Team Project
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@isazi @benvanwerkhoven @egpbos