Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDTSC_VMEXIT test is not accurate #53

Closed
fameowner99 opened this issue Mar 17, 2024 · 4 comments
Closed

RDTSC_VMEXIT test is not accurate #53

fameowner99 opened this issue Mar 17, 2024 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@fameowner99
Copy link
Contributor

I have slow windows PC and this test say that I am running VM but it's not true.

line 3271 | return (avg >= 1000 || avg == 0);

wrong because I have avg = ~1500.

@kernelwernel kernelwernel added bug Something isn't working good first issue Good for newcomers labels Mar 17, 2024
@kernelwernel
Copy link
Owner

I'll increase the threshold to 1500 then. Thanks for reporting on this 👍

@kernelwernel
Copy link
Owner

bfc28a2

@fameowner99
Copy link
Contributor Author

fameowner99 commented Mar 18, 2024

But it is somekind of tradeoff.
You don't know which exact value you need to check so it will be false positive or false negative.
Maybe need to think about changing test logic.

@kernelwernel
Copy link
Owner

But it is somekind of tradeoff. You don't know which exact value you need to check so it will be false positive or false negative. Maybe need to think about changing test logic.

in all fairness, some techniques can have false positives in their design. That's why I added a certainty score of the RDTSC_VMEXIT technique to 35%. I could definitely lower it due to what you said, but I sort of need second opinions on what the new certainty score should be (maybe 15?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants