Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake overdamage from environmental sources #707

Open
LaughNgamez opened this issue Jan 22, 2024 · 33 comments
Open

Fake overdamage from environmental sources #707

LaughNgamez opened this issue Jan 22, 2024 · 33 comments
Labels
awaiting testing The fix to the issue has yet to be tested by the user bug This is a confirmed bug

Comments

@LaughNgamez
Copy link

LaughNgamez commented Jan 22, 2024

Information

  • Server Version: 1.20.2 PaperMC
  • OldCombatMechanics version: Jenkins build 1.13 #207
config.yml
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at https://mozilla.org/MPL/2.0/.

# ############# OldCombatMechanics Plugin by kernitus and Rayzr522 ##########
#                                                                           #
# Bukkit Page: http://dev.bukkit.org/bukkit-plugins/oldcombatmechanics/     #
# Spigot Page: https://www.spigotmc.org/resources/oldcombatmechanics.19510/ #
# GitHub Page: https://github.com/kernitus/BukkitOldCombatMechanics/        #
#                                                                           #
# ###########################################################################

modesets:
  # These modesets are lists of modules that are enabled for a player in that mode.
  # Modules not listed in any modeset are assumed to always be available.
  # You can create as many modesets as you like by adding a new key and corresponding list.
  # When in PvP, the modeset of the attacker is checked first.
  # If not PvP, the modeset of the defending entity is checked.
  # Of course, the module must also be enabled in its own config section.
  # Sample below has modules enabled for "old" combat modeset and disabled for "new" combat modeset
  # PlaceholderAPI: %ocm_modeset%
  old:
      - "disable-attack-cooldown"
      - "disable-sword-sweep"
      - "disable-offhand"
      - "old-tool-damage"
      - "sword-blocking"
      - "shield-damage-reduction"
      - "old-golden-apples"
      - "old-player-knockback"
      - "old-player-regen"
      - "old-armour-strength"
      - "old-potion-effects"
      - "old-critical-hits"
  new:

worlds:
  # These are the modesets available in each world.
  # If player has no modeset when moving worlds they'll be assigned first mode in list,
  # unless the mode from the world they are coming from is also available in the new world.
  # Worlds not specified below will have all modesets available.
  world: ["old", "new"]
  world_nether: ["old", "new"]
  world_the_end: ["old", "new"]
  # old_world: ["old"]
  # brave_new_world: ["new"]

mode-messages:
  # Messages used when changing player mode
  mode-status: "&bYour current modeset is: &7%s"
  message-usage: "&eYou can use &c/ocm mode <modeset> [player] &eto change modeset"
  invalid-modeset: "&cPlease specify a valid modeset!"
  invalid-player: "&cPlease specify a valid player!"
  mode-set: "&2Set modeset to &7%s"

# ########################
# COMBAT MODULE SETTINGS
# ########################

disable-attack-cooldown:
  # This is to disable the attack cooldown
  enabled: true
  # What to set the attack speed to. Default for 1.9 is 4, at least 40 is needed for no cooldown.
  generic-attack-speed: 40

attack-frequency:
  # Allows changing the player invulnerability between hits
  enabled: false
  # The hit delay to apply. Default for 1.9+ is 20 ticks (1 second)
  playerDelay: 18
  mobDelay: 16

old-tool-damage:
  # This is to set the tool damage as in pre-1.9
  # IMPORTANT: Also enable disable-sword-sweep module or sweeps will have the damage value of the weapon in hand
  # NOTE: this will modify the damage, however the item tooltip will still show the 1.9+ damage
  enabled: true
  # Use old sharpness calculations, i.e. each level adds 1.25 damage
  # In 1.9+, sharpness adds 1 + 0.5 * level damage
  old-sharpness: true
  # Damage values shown in 1.9 representation (actual damage)
  # In 1.8 the damage tooltip value would be added to 1 'base damage', yielding the values below
  damages:
    # Axe damages
    GOLD_AXE: 4
    WOOD_AXE: 4
    STONE_AXE: 5
    IRON_AXE: 6
    DIAMOND_AXE: 7
    NETHERITE_AXE: 8
    # Shovel damages
    GOLD_SPADE: 2
    WOOD_SPADE: 2
    STONE_SPADE: 3
    IRON_SPADE: 4
    DIAMOND_SPADE: 5
    NETHERITE_SPADE: 6
    # Sword damages
    GOLD_SWORD: 5
    WOOD_SWORD: 5
    STONE_SWORD: 6
    IRON_SWORD: 7
    DIAMOND_SWORD: 8
    NETHERITE_SWORD: 9
    # Pickaxe damages
    GOLD_PICKAXE: 3
    WOOD_PICKAXE: 3
    STONE_PICKAXE: 4
    IRON_PICKAXE: 5
    DIAMOND_PICKAXE: 6
    NETHERITE_PICKAXE: 7
    # Hoe damages
    GOLD_HOE: 1
    WOOD_HOE: 1
    STONE_HOE: 1
    IRON_HOE: 1
    DIAMOND_HOE: 1
    NETHERITE_HOE: 1

old-critical-hits:
  # Makes critical hits work like in 1.8
  # With a critical hit, the damage will be multiplied by 1.5
  # In 1.9, the user must also not be sprinting for it to be a crit
  enabled: false
  world: [ ]
  # What the damage, after applying potions effects, is multiplied by
  multiplier: 1.5
  # Whether to allow crits while sprinting. 1.8: true, 1.9: false
  allow-sprinting: true

old-player-regen:
  # This is to make players' regeneration act mostly like it did in pre-1.9
  # Based on https://minecraft.gamepedia.com/Hunger?oldid=948685
  enabled: false
  # How often a player should regenerate health, in milliseconds (In 1.8: 4 seconds)
  # The foodTickerTimer might not be perfectly accurate so we give it ~10ms of leeway
  interval: 3990
  # How many half-hearts the player should heal by, every seconds specified above
  amount: 1
  # How much exhaustion the player should get from healing. In 1.8: 3    In 1.9: 4    In 1.11: 6
  # If, after adding this, Minecraft finds the value is above 4, it subtracts 4
  # and either reduces saturation or, if saturation is 0, reduces food level by 1 (1/2 a stick)
  exhaustion: 3

# ########################
# ARMOUR
# ########################

old-armour-strength:
  # This is to make armour calculations like in 1.8
  # Based on this: https://minecraft.gamepedia.com/index.php?title=Armor&oldid=909187
  enabled: false
  # Whether to introduce randomness in the calculation, as in 1.8
  randomness: true

old-armour-durability:
  # This makes armour take a constant amount of durability damage (except for explosions)
  enabled: true
  # By how much to reduce durability every attack. 1.8 default is 1
  reduction: 1

# ########################
# SWEEP, SHIELDS & BLOCKING
# ########################

shield-damage-reduction:
  # This module allows changing the damage reduction behaviour of shields
  enabled: false
  # How much damage blocking should reduce
  # Firstly, amount is subtracted, then value is multiplied by percentage
  # 1.8: (damage - 1) * 50%    1.9: damage * 33%   1.11: damage * 0%
  # Damage reduction = (damage - damageReductionAmount) * damageReductionPercentage / 100
  generalDamageReductionAmount: 1
  generalDamageReductionPercentage: 50
  # This value works the same but is exclusively for projectile damage
  # Set amount to 0 and percentage to 100 for 1.8 behaviour, i.e. arrows go through shields
  projectileDamageReductionAmount: 1
  projectileDamageReductionPercentage: 50

sword-blocking:
  # This is to allow players to block with swords again, by getting a shield while they hold right click with a sword
  enabled: false
  # How often, in ticks, OCM should check if the player is still blocking with a shield, and remove it if not
  # If this is too fast, the player will have their shield disappear before they're able to block again causing a slight delay
  # If this is too slow, players will have a shield in their hand well after they've stopped blocking
  # 20 ticks = 1 second
  restoreDelay: 40
  # Whether to require players to have oldcombatmechanics.swordblock permission to block with a sword
  use-permission: false

disable-sword-sweep:
  # This is to disable the sword sweep attack
  # With ProtocolLib, particle effect is also removed
  enabled: false

disable-sword-sweep-particles:
  # This is to disable the sword sweep attack particles
  # Requires ProtocolLib
  enabled: false

# ########################
# KNOCKBACK
# ########################

old-player-knockback:
  # This is to change knockback players receive from attacks.  Default values are as in 1.8.
  #
  # Practice servers tend to use lower knockback, for example:
  # knockback-horizontal: 0.35
  # knockback-vertical: 0.35
  # knockback-vertical-limit: 0.4
  # knockback-extra-horizontal: 0.425
  # knockback-extra-vertical: 0.085
  #
  # Minigame servers use higher vertical knockback and lower horizontal knockback, exact values are unknown.
  enabled: false
  # Horizontal knockback is reduced by 40% for every successful attack by the player, with no limit
  # Increase to make clicking more important, decrease to make it less important
  knockback-horizontal: 0.4
  # Vertical knockback is not reduced by clicking faster
  # Increase to make clicking less important, decrease to make clicking more important
  knockback-vertical: 0.4
  # Vertical knockback limit is applied after base vertical knockback
  # This limit can be exceeded by sprint hitting or knockback enchantments, from the extra vertical knockback
  knockback-vertical-limit: 0.4
  # Extra horizontal knockback is applied for each level of knockback enchant, and for sprinting
  # Increase to make sprint resetting (w-tapping) more important, decrease to make it less important
  # Increase to make clicking more important, decrease to make clicking less important
  knockback-extra-horizontal: 0.5
  # Extra vertical knockback is applied for each level of knockback enchant, and for sprinting
  # Increase to make sprint resetting (w-tapping) more important, decrease to make it less important
  # Increase to make clicking less important, decrease to make clicking more important
  knockback-extra-vertical: 0.1
  # Should knockback resistance be enabled? (e.g. netherite armour knockback resistance)
  enable-knockback-resistance: false

old-fishing-knockback:
  # This is to make the knockback of players when they get hit by a fishing bobber the same as it was in pre-1.9
  enabled: false
  # This is the damage done by the fishing rod attack
  damage: 0.0001
  # This is to cancel dragging in the entity attached to the fishing rod when reeling in, like in 1.8
  # Options: all, players, mobs, none. players allows compatibility with WorldGuard pvp-deny regions
  cancelDraggingIn: players
  # Whether to also give knockback on non-player living entities (e.g. mobs)
  knockbackNonPlayerEntities: false
  # This is the delay in milliseconds in-between rod damage, so the player hit has time to fall back down
  hitCooldown: 1000

fishing-rod-velocity:
  # In 1.9+ fishing rods go 8 blocks instead of 12 blocks
  # This is due to both gravity and initial launch speed
  # Set to true to revert back to the old calculations and gravity
  enabled: false

projectile-knockback:
  # This adds knockback and/or damage to players when they get hit by snowballs, eggs & enderpearls
  # This has been a Bukkit bug for so long people thought it was vanilla when it was patched
  enabled: false
  # This is the damage done by each projectile
  damage:
    snowball: 0.0001
    egg: 0.0001
    ender_pearl: 0.0001

# ########################
# GAPPLES & POTIONS
# ########################

old-golden-apples:
  # This is to change the behaviour / crafting of golden apples to how it was in pre-1.9
  # WARNING: If on 1.12 or above and you disable this module you must reload the server for the recipe to disappear
  enabled: false
  # Cooldown between eating the apples, in seconds
  cooldown:
    # The cooldown for normal golden apples
    # PlaceholderAPI: %ocm_gapple_cooldown%
    normal: 0
    # Message when user tries to eat golden apple during cooldown. Leave empty to disable.
    message-normal: "&ePlease wait %seconds%s before eating another golden apple."
    # The cooldown for enchanted golden apples
    # PlaceholderAPI: %ocm_napple_cooldown%
    enchanted: 0
    # Message when user tries to eat enchanted golden apple during cooldown. Leave empty to disable.
    message-enchanted: "&ePlease wait %seconds%s before eating another enchanted golden apple."
    # Whether the two apple types share a cooldown.
    # If this is true:
    #   1. Eating any apple resets both cooldowns
    #   2. Each apple type can only be eaten when its cooldown time is over
    #      This means that when you eat *any* apple you start two parallel cooldowns: One for enchanted and one
    #      for normal apples. Each type can only be eaten when its cooldown is over.
    #      Once any apple is eaten, both cooldowns are restarted, so you can not eat either type again
    #      before its full cooldown is over.
    #   3. To have the plugin treat normal and enchanted golden apples as having the same cooldown,
    #      then set the same cooldown time and enable shared mode. (This was the old mode)
    # If this is false:
    #   Eating an enchanted apple will prevent any *enchanted* apple type from being eaten before the cooldown is over
    #   Eating a normal apple will prevent any *normal* apple type from being eaten before the normal cooldown is over
    is-shared: false
  # If you want to allow enchanted golden apple crafting
  enchanted-golden-apple-crafting: true
  # Enabling this makes the potion effects gained by eating golden apples
  # and enchanted golden apples the same as it was in pre-1.9
  old-potion-effects: true
  # Potion effects golden apples should apply
  # Duration is in ticks (20 ticks = 1 second)
  # Amplifier is the potion level - 1, so Regeneration IV would be amplifier 3
  gapple-effects:
    regeneration:
      duration: 100
      amplifier: 1
    absorption:
      duration: 2400
      amplifier: 0
  # Potion effects enchanted golden apples should apply
  napple-effects:
    regeneration:
      duration: 600
      amplifier: 4
    damage_resistance:
      duration: 6000
      amplifier: 0
    fire_resistance:
      duration: 6000
      amplifier: 0
    absorption:
      duration: 2400
      amplifier: 0
  # Enable this if you have another plugin which adds a crafting recipe for
  # enchanted golden apples (requires server restart)
  no-conflict-mode: false

old-potion-effects:
  # This is to restore the 1.8 potion effects and duration
  enabled: false

  # DURATION: (in seconds)
  potion-durations:
    regen: # Regeneration
      drinkable:
        base: 45
        II: 22
        extended: 120
      splash:
        base: 33
        II: 16
        extended: 90

    speed: # Swiftness
      drinkable:
        base: 180
        II: 90
        extended: 480
      splash:
        base: 135
        II: 67
        extended: 360

    fire_resistance:
      drinkable:
        base: 180
        extended: 480
      splash:
        base: 135
        extended: 360

    poison:
      drinkable:
        base: 45
        II: 22
        extended: 120
      splash:
        base: 33
        II: 16
        extended: 90

    night_vision:
      drinkable:
        base: 180
        extended: 480
      splash:
        base: 180
        extended: 480

    weakness:
      drinkable:
        base: 90
        extended: 240
      splash:
        base: 90
        extended: 240

    strength:
      drinkable:
        base: 180
        II: 90
        extended: 480
      splash:
        base: 135
        II: 67
        extended: 360

    slowness:
      drinkable:
        base: 90
        extended: 240
      splash:
        base: 67
        extended: 180

    jump: # Leaping
      drinkable:
        base: 180
        II: 90
        extended: 480
      splash:
        base: 135
        II: 67
        extended: 360

    water_breathing:
      drinkable:
        base: 180
        extended: 480
      splash:
        base: 135
        extended: 360

    invisibility:
      drinkable:
        base: 180
        extended: 480
      splash:
        base: 135
        extended: 360

    # 1.9+ potions
    # Turtle Master potion currently incompatible, will just work like default
    luck:
      drinkable:
        base: 300
      splash:
        base: 300

    slow_falling:
      drinkable:
        base: 90
        extended: 240
      splash:
        base: 90
        extended: 240

  # EFFECTS
  # If 'multiplier' is true value is multiplied by base tool damage. If 'addend' it is added.
  # If both true, it is first increased by 1 then multiplied (same as +xx%)
  # Strength potion
  # 1.9: I = +3; II = +6;    1.8: I = +130%; II = +260%
  strength:
    modifier: 1.3
    multiplier: true
    addend: true
  # Weakness potion
  # 1.9 value: -4   1.8 value: -0.5
  weakness:
    modifier: -0.5
    multiplier: false

# ########################
# MISCELLANEOUS
# ########################

disable-crafting:
  # Disable the crafting of specified items
  enabled: false
  # List of denied items
  denied:
    - shield
  # Show the user a message if they try to craft a blacklisted item
  showMessage: true
  message: "&cYou cannot craft that item!"

disable-offhand:
  # Disable the usage of the offhand
  # Won't affect sword-blocking module
  enabled: false
  # Whether the following list allows items or blocks them
  whitelist: true
  # List of items that should be allowed/blocked
  # Example: [diamond_sword,BOW]
  items: [ ]
  # Message to send user when denied. Set to '' to disable
  denied-message: "&cOff-hand is disabled"

old-brewing-stand:
  # Automatically refuels brewing stands
  enabled: false

no-lapis-enchantments:
  # Automatically adds lapis to enchantment tables upon opening
  enabled: false
  # Whether to only allow this for players with oldcombatmechanics.nolapis permission
  usePermission: false

disable-elytra:
  # Do not allow players to wear elytra
  enabled: false

disable-enderpearl-cooldown:
  # Disables enderpearl cooldown
  enabled: false
  # The cooldown, in seconds
  # PlaceholderAPI: %ocm_enderpearl_cooldown%
  cooldown: 0
  # Show the user a message if they try to use an enderpearl and the cooldown has not expired yet
  showMessage: true
  message: "&cYou must wait &7%ds&c before using an enderpearl again!"

chorus-fruit:
  # This makes the chorus fruit behaviour configurable
  enabled: false
  # The maximum distance the fruit can teleport the player. This a PER AXIS value, so this outlines a cube with
  # 2 * max-teleportation-distance as the side length
  # Vanilla default is 8.
  # Setting this to 0 disables chorus fruit teleport.
  # Setting this to a value greater than 8 MIGHT CAUSE CONFLICTS with bukkit's internal anti cheat
  # and *potentially* any other anti-cheat you use. Please make sure this is not an issue before increasing
  # this value.
  max-teleportation-distance: 8
  # Whether to prevent eating the fruit completely. This also prevents the teleportation.
  prevent-eating: false
  # The saturation value of the chorus fruit.
  # Vanilla default is 2.4
  saturation-value: 2.4
  # The hunger value of the chorus fruit.
  # Vanilla default is 4 (2 bars)
  hunger-value: 4

old-burn-delay:
  # This makes it so entities will immediately start to burn when entering fire
  enabled: false
  # How long, in ticks, entities should be on fire for after not being in direct contact anymore
  fire-ticks: 120

disable-projectile-randomness:
  # This is to remove projectile randomness while firing arrows with a bow
  # Or to remove effects of velocity when player is running and launching potions etc
  # This is actually a very old feature and has been in the game for quite some time
  enabled: false
  # What projectiles are affected e.g. arrow, splash_potion, snowball, egg, fishing_hook
  projectile-types: [ arrow ]
  # This is the threshold between projectiles' (X,Z) values before they're considered the same and straightened
  # This value is only useful for multishot. The default of 0.1 works at all but extremely shallow angles,
  # where arrows end up bunched together. Set to 1 if you want multishots to all follow the same path.
  epsilon: 0.1

disable-bow-boost:
  # This is to stop players from boosting themselves forward by hitting themselves
  # while running with a punch II arrow from their bow
  # This module simply stops them from hitting themselves with arrows entirely
  enabled: false

disable-attack-sounds:
  # Disables attack sounds that were added with 1.9+
  # Requires ProtocolLib
  enabled: false
  # The sounds that will be blocked by this module
  blocked-sound-names:
    - "ENTITY_PLAYER_ATTACK_STRONG"
    - "ENTITY_PLAYER_ATTACK_SWEEP"
    - "ENTITY_PLAYER_ATTACK_NODAMAGE"
    - "ENTITY_PLAYER_ATTACK_KNOCKBACK"
    - "ENTITY_PLAYER_ATTACK_CRIT"
    - "ENTITY_PLAYER_ATTACK_WEAK"

disable-player-collisions:
  # This is to disable player collisions
  # This is compatible with most scoreboard and tablist-editing plugins
  enabled: false

# ########################
# SPECIAL SETTINGS BELOW #
# ########################

message-prefix: "&6[OCM]&r"

# This is to toggle the update checker
update-checker:
  # Whether to check for updates and notify players with the oldcombatmechanics.notify permission
  enabled: false
  # Whether to automatically download an update of the plugin
  # The update is applied on the next restart/reload of the server
  # Auto update is disabled if Spigot version is below 1.18.1 and force-below-1-18-1-config-upgrade is false
  # This is to prevent accidentally resetting the config
  auto-update: true

# Whether to force config upgrade even in Spigot versions below 1.18.1
# This is not advised, as all the comments would be removed
force-below-1-18-1-config-upgrade: false

# This enables command argument completion when pressing tab
command-completer:
  enabled: false

# This enables debug messages, only enable when troubleshooting
debug:
  enabled: true

# DO NOT CHANGE THIS NUMBER AS IT WILL RESET YOUR CONFIG
config-version: 63

Log: https://hastebin.com/share/arikobufuw.makefile

Output log: https://www.toptal.com/developers/hastebin

Problem Description

It seems there's an issue of fire aspect enchantment dealing a lot more damage than intended, seemingly bypassing hit intervals with rapid clicks/high tps. (More than would be expected from regular fire aspect).

Attacking a player in protection 4 with a base diamond sword, fire aspect vs no fire aspect

fire.aspect.mp4
no.fire.aspect.mp4

To Reproduce

Steps to reproduce the behavior:

  1. Wear protection 4 armour
  2. Be attacked with regular diamond sword at high click speed
  3. Be attacked with fire aspect 2 diamond sword at high click speed
  4. See just how much higher damage is

Expected Behaviour

Damage should not be so much higher, it seems extra hits are registering or something.

Actual Behaviour

Players die at very very high speeds

@LaughNgamez LaughNgamez added the investigate We have yet to investigate this issue label Jan 22, 2024
@NarutoSMP

This comment was marked as duplicate.

@LaughNgamez

This comment was marked as off-topic.

@NotAlexNoyle
Copy link

In addition to killing players too fast, this also causes armor durability to go down way faster than it should.

@kernitus
Copy link
Owner

Information

* Server Version:  1.20.2 PaperMC

* OldCombatMechanics version: Jenkins build [1.13 #207](https://github.com/kernitus/BukkitOldCombatMechanics/issues/207)

Config: https://hastebin.com/share/loqixipipe.yaml Log: https://hastebin.com/share/arikobufuw.makefile

Output log: https://www.toptal.com/developers/hastebin

Problem Description

It seems there's an issue of fire aspect enchantment dealing a lot more damage than intended, seemingly bypassing hit intervals with rapid clicks/high tps. (More than would be expected from regular fire aspect).

Attacking a player in protection 4 with a base diamond sword, fire aspect vs no fire aspect
fire.aspect.mp4
no.fire.aspect.mp4

To Reproduce

Steps to reproduce the behavior:

1. Wear protection 4 armour

2. Be attacked with regular diamond sword at high click speed

3. Be attacked with fire aspect 2 diamond sword at high click speed

4. See just how much higher damage is

Expected Behaviour

Damage should not be so much higher, it seems extra hits are registering or something.

Actual Behaviour

Players die at very very high speeds

  1. Can you provide a minimal working example, with no armour involved?
  2. Can you paste the debug log for the example from the console?

@LaughNgamez
Copy link
Author

Sadly I’m out of town until Wednesday is there a chance @NotAlexNoyle could you post it?

@LaughNgamez
Copy link
Author

https://hastebin.com/share/irobesesep.markdown

There's the debug. The first 470 lines of text are attacking with a regular stick. After line 470 it's with a fire aspect 1 stick. It's much much quicker and that was even without a rapid clicker.

Thank you

@kernitus
Copy link
Owner

kernitus commented Feb 6, 2024

https://hastebin.com/share/irobesesep.markdown

There's the debug. The first 470 lines of text are attacking with a regular stick. After line 470 it's with a fire aspect 1 stick. It's much much quicker and that was even without a rapid clicker.

Thank you

Ok thanks for the log, i will investigate when i have time. Can you please reupload the config.yml or just paste it in the text as code, it seems to have been deleted.

@LaughNgamez
Copy link
Author

https://hastebin.com/share/irobesesep.markdown
There's the debug. The first 470 lines of text are attacking with a regular stick. After line 470 it's with a fire aspect 1 stick. It's much much quicker and that was even without a rapid clicker.
Thank you

Ok thanks for the log, i will investigate when i have time. Can you please reupload the config.yml or just paste it in the text as code, it seems to have been deleted.

https://hastebin.com/share/fikonocomi.yaml Here is the config, although it occurs with a totally fresh/modified config I believe.

@LaughNgamez

This comment was marked as off-topic.

@kernitus
Copy link
Owner

https://hastebin.com/share/irobesesep.markdown
There's the debug. The first 470 lines of text are attacking with a regular stick. After line 470 it's with a fire aspect 1 stick. It's much much quicker and that was even without a rapid clicker.
Thank you

Ok thanks for the log, i will investigate when i have time. Can you please reupload the config.yml or just paste it in the text as code, it seems to have been deleted.

https://hastebin.com/share/fikonocomi.yaml Here is the config, although it occurs with a totally fresh/modified config I believe.

I'm going to need you to paste the debug logs for with and without fire aspect into an actual comment, hastebin keeps deleting them.

@LaughNgamez
Copy link
Author

LaughNgamez commented Feb 15, 2024

https://hastebin.com/share/irobesesep.markdown
There's the debug. The first 470 lines of text are attacking with a regular stick. After line 470 it's with a fire aspect 1 stick. It's much much quicker and that was even without a rapid clicker.
Thank you

Ok thanks for the log, i will investigate when i have time. Can you please reupload the config.yml or just paste it in the text as code, it seems to have been deleted.

https://hastebin.com/share/fikonocomi.yaml Here is the config, although it occurs with a totally fresh/modified config I believe.

I'm going to need you to paste the debug logs for with and without fire aspect into an actual comment, hastebin keeps deleting them.

latest.log
Uploaded log

and for good measure: https://pastebin.com/LEU0knAr

@LaughNgamez
Copy link
Author

First death was with a stone, 2nd was with a stone with fire aspect that takes about 1/5th of the time

@LaughNgamez

This comment was marked as spam.

@pixeldev

This comment was marked as spam.

@artemati1

This comment was marked as spam.

@USBCharger

This comment was marked as spam.

@kernitus
Copy link
Owner

Please stop spamming without contributing anything new to the discussion. If you just want to say you have the same issue then thumbs up the first post.

@kernitus kernitus added bug This is a confirmed bug awaiting testing The fix to the issue has yet to be tested by the user and removed investigate We have yet to investigate this issue labels Mar 16, 2024
@kernitus
Copy link
Owner

Ok I believe I have identified the issue and fixed it. It seems we were not checking for fake overdamage when players received damage from environmental source (i.e. not combat). Please try test version 215 and let me know if there are still problems with fire aspect damage.

@kernitus kernitus changed the title Very fast death with fire aspect & high click speed Fake overdamage from environmental sources Mar 16, 2024
@USBCharger
Copy link

image
TLDR: Whack a an prot 4 player with a max sharp, sweep, and fire sword a bunch and you'll do no dmg aside from fire tick. It does dmg the armour/naked players though. Lmk if you need my config

@kernitus
Copy link
Owner

image TLDR: Whack a an prot 4 player with a max sharp, sweep, and fire sword a bunch and you'll do no dmg aside from fire tick. It does dmg the armour/naked players though. Lmk if you need my config

That doesn't meant anything. I'd need to know the exact test version you're running, the version of the server, and get a copy of your config.yml and the debug output from the attacks

@USBCharger
Copy link

USBCharger commented Mar 17, 2024

I clicked the link provided, so it would have been ver 215, server is running paper 1.20.4-436.

config.yml
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at https://mozilla.org/MPL/2.0/.

# ############# OldCombatMechanics Plugin by kernitus and Rayzr522 ##########
#                                                                           #
# Bukkit Page: http://dev.bukkit.org/bukkit-plugins/oldcombatmechanics/     #
# Spigot Page: https://www.spigotmc.org/resources/oldcombatmechanics.19510/ #
# GitHub Page: https://github.com/kernitus/BukkitOldCombatMechanics/        #
#                                                                           #
# ###########################################################################

modesets:
  # These modesets are lists of modules that are enabled for a player in that mode.
  # Modules not listed in any modeset are assumed to always be available.
  # You can create as many modesets as you like by adding a new key and corresponding list.
  # When in PvP, the modeset of the attacker is checked first.
  # If not PvP, the modeset of the defending entity is checked.
  # Of course, the module must also be enabled in its own config section.
  # Sample below has modules enabled for "old" combat modeset and disabled for "new" combat modeset
  # PlaceholderAPI: %ocm_modeset%
  old:
      - "disable-attack-cooldown"
      - "disable-sword-sweep"
      - "disable-offhand"
      - "old-tool-damage"
      - "sword-blocking"
      - "shield-damage-reduction"
      - "old-golden-apples"
      - "old-player-knockback"
      - "old-player-regen"
      - "old-armour-strength"
      - "old-potion-effects"
      - "old-critical-hits"
  new: [ ]

worlds:
  # These are the modesets available in each world.
  # If player has no modeset when moving worlds they'll be assigned first mode in list,
  # unless the mode from the world they are coming from is also available in the new world.
  # Worlds not specified below will have all modesets available.
  world: ["old", "new"]
  world_nether: ["old", "new"]
  world_the_end: ["old", "new"]
  # old_world: ["old"]
  # brave_new_world: ["new"]

mode-messages:
  # Messages used when changing player mode
  mode-status: "&bYour current modeset is: &7%s"
  message-usage: "&eYou can use &c/ocm mode <modeset> [player] &eto change modeset"
  invalid-modeset: "&cPlease specify a valid modeset!"
  invalid-player: "&cPlease specify a valid player!"
  mode-set: "&2Set modeset to &7%s"

# ########################
# COMBAT MODULE SETTINGS
# ########################

disable-attack-cooldown:
  # This is to disable the attack cooldown
  enabled: true
  # What to set the attack speed to. Default for 1.9 is 4, at least 40 is needed for no cooldown.
  generic-attack-speed: 40

attack-frequency:
  # Allows changing the player invulnerability between hits
  enabled: true
  # The hit delay to apply. Default for 1.9+ is 20 ticks (1 second)
  playerDelay: 20
  mobDelay: 20

old-tool-damage:
  # This is to set the tool damage as in pre-1.9
  # IMPORTANT: Also enable disable-sword-sweep module or sweeps will have the damage value of the weapon in hand
  # NOTE: this will modify the damage, however the item tooltip will still show the 1.9+ damage
  enabled: true
  # Use old sharpness calculations, i.e. each level adds 1.25 damage
  # In 1.9+, sharpness adds 1 + 0.5 * level damage
  old-sharpness: true
  # Damage values shown in 1.9 representation (actual damage)
  # In 1.8 the damage tooltip value would be added to 1 'base damage', yielding the values below
  damages:
    # Axe damages
    GOLD_AXE: 4
    WOOD_AXE: 4
    STONE_AXE: 5
    IRON_AXE: 6
    DIAMOND_AXE: 7
    NETHERITE_AXE: 8
    # Shovel damages
    GOLD_SPADE: 2
    WOOD_SPADE: 2
    STONE_SPADE: 3
    IRON_SPADE: 4
    DIAMOND_SPADE: 5
    NETHERITE_SPADE: 6
    # Sword damages
    GOLD_SWORD: 5
    WOOD_SWORD: 5
    STONE_SWORD: 6
    IRON_SWORD: 7
    DIAMOND_SWORD: 8
    NETHERITE_SWORD: 9
    # Pickaxe damages
    GOLD_PICKAXE: 3
    WOOD_PICKAXE: 3
    STONE_PICKAXE: 4
    IRON_PICKAXE: 5
    DIAMOND_PICKAXE: 6
    NETHERITE_PICKAXE: 7
    # Hoe damages
    GOLD_HOE: 1
    WOOD_HOE: 1
    STONE_HOE: 1
    IRON_HOE: 1
    DIAMOND_HOE: 1
    NETHERITE_HOE: 1

old-critical-hits:
  # Makes critical hits work like in 1.8
  # With a critical hit, the damage will be multiplied by 1.5
  # In 1.9, the user must also not be sprinting for it to be a crit
  enabled: true
  world: [ ]
  # What the damage, after applying potions effects, is multiplied by
  multiplier: 1.5
  # Whether to allow crits while sprinting. 1.8: true, 1.9: false
  allow-sprinting: true

old-player-regen:
  # This is to make players' regeneration act mostly like it did in pre-1.9
  # Based on https://minecraft.gamepedia.com/Hunger?oldid=948685
  enabled: false
  # How often a player should regenerate health, in milliseconds (In 1.8: 4 seconds)
  # The foodTickerTimer might not be perfectly accurate so we give it ~10ms of leeway
  interval: 3990
  # How many half-hearts the player should heal by, every seconds specified above
  amount: 1
  # How much exhaustion the player should get from healing. In 1.8: 3    In 1.9: 4    In 1.11: 6
  # If, after adding this, Minecraft finds the value is above 4, it subtracts 4
  # and either reduces saturation or, if saturation is 0, reduces food level by 1 (1/2 a stick)
  exhaustion: 3

# ########################
# ARMOUR
# ########################

old-armour-strength:
  # This is to make armour calculations like in 1.8
  # Based on this: https://minecraft.gamepedia.com/index.php?title=Armor&oldid=909187
  enabled: true
  # Whether to introduce randomness in the calculation, as in 1.8
  randomness: false

old-armour-durability:
  # This makes armour take a constant amount of durability damage (except for explosions)
  enabled: true
  # By how much to reduce durability every attack. 1.8 default is 1
  reduction: 1

# ########################
# SWEEP, SHIELDS & BLOCKING
# ########################

shield-damage-reduction:
  # This module allows changing the damage reduction behaviour of shields
  enabled: true
  # How much damage blocking should reduce
  # Firstly, amount is subtracted, then value is multiplied by percentage
  # 1.8: (damage - 1) * 50%    1.9: damage * 33%   1.11: damage * 0%
  # Damage reduction = (damage - damageReductionAmount) * damageReductionPercentage / 100
  generalDamageReductionAmount: 1
  generalDamageReductionPercentage: 100
  # This value works the same but is exclusively for projectile damage
  # Set amount to 0 and percentage to 100 for 1.8 behaviour, i.e. arrows go through shields
  projectileDamageReductionAmount: 1
  projectileDamageReductionPercentage: 100

sword-blocking:
  # This is to allow players to block with swords again, by getting a shield while they hold right click with a sword
  enabled: false
  # How often, in ticks, OCM should check if the player is still blocking with a shield, and remove it if not
  # If this is too fast, the player will have their shield disappear before they're able to block again causing a slight delay
  # If this is too slow, players will have a shield in their hand well after they've stopped blocking
  # 20 ticks = 1 second
  restoreDelay: 40
  # Whether to require players to have oldcombatmechanics.swordblock permission to block with a sword
  use-permission: false

disable-sword-sweep:
  # This is to disable the sword sweep attack
  # With ProtocolLib, particle effect is also removed
  enabled: false

disable-sword-sweep-particles:
  # This is to disable the sword sweep attack particles
  # Requires ProtocolLib
  enabled: false

# ########################
# KNOCKBACK
# ########################

old-player-knockback:
  # This is to change knockback players receive from attacks.  Default values are as in 1.8.
  #
  # Practice servers tend to use lower knockback, for example:
  # knockback-horizontal: 0.35
  # knockback-vertical: 0.35
  # knockback-vertical-limit: 0.4
  # knockback-extra-horizontal: 0.425
  # knockback-extra-vertical: 0.085
  #
  # Minigame servers use higher vertical knockback and lower horizontal knockback, exact values are unknown.
  enabled: false
  # Horizontal knockback is reduced by 40% for every successful attack by the player, with no limit
  # Increase to make clicking more important, decrease to make it less important
  knockback-horizontal: 0.4
  # Vertical knockback is not reduced by clicking faster
  # Increase to make clicking less important, decrease to make clicking more important
  knockback-vertical: 0.4
  # Vertical knockback limit is applied after base vertical knockback
  # This limit can be exceeded by sprint hitting or knockback enchantments, from the extra vertical knockback
  knockback-vertical-limit: 0.4
  # Extra horizontal knockback is applied for each level of knockback enchant, and for sprinting
  # Increase to make sprint resetting (w-tapping) more important, decrease to make it less important
  # Increase to make clicking more important, decrease to make clicking less important
  knockback-extra-horizontal: 0.5
  # Extra vertical knockback is applied for each level of knockback enchant, and for sprinting
  # Increase to make sprint resetting (w-tapping) more important, decrease to make it less important
  # Increase to make clicking less important, decrease to make clicking more important
  knockback-extra-vertical: 0.1
  # Should knockback resistance be enabled? (e.g. netherite armour knockback resistance)
  enable-knockback-resistance: false

old-fishing-knockback:
  # This is to make the knockback of players when they get hit by a fishing bobber the same as it was in pre-1.9
  enabled: true
  # This is the damage done by the fishing rod attack
  damage: 0.0001
  # This is to cancel dragging in the entity attached to the fishing rod when reeling in, like in 1.8
  # Options: all, players, mobs, none. players allows compatibility with WorldGuard pvp-deny regions
  cancelDraggingIn: players
  # Whether to also give knockback on non-player living entities (e.g. mobs)
  knockbackNonPlayerEntities: false
  # This is the delay in milliseconds in-between rod damage, so the player hit has time to fall back down
  hitCooldown: 1000

fishing-rod-velocity:
  # In 1.9+ fishing rods go 8 blocks instead of 12 blocks
  # This is due to both gravity and initial launch speed
  # Set to true to revert back to the old calculations and gravity
  enabled: true

projectile-knockback:
  # This adds knockback and/or damage to players when they get hit by snowballs, eggs & enderpearls
  # This has been a Bukkit bug for so long people thought it was vanilla when it was patched
  enabled: true
  # This is the damage done by each projectile
  damage:
    snowball: 0.0001
    egg: 0.0001
    ender_pearl: 0.0001

# ########################
# GAPPLES & POTIONS
# ########################

old-golden-apples:
  # This is to change the behaviour / crafting of golden apples to how it was in pre-1.9
  # WARNING: If on 1.12 or above and you disable this module you must reload the server for the recipe to disappear
  enabled: false
  # Cooldown between eating the apples, in seconds
  cooldown:
    # The cooldown for normal golden apples
    # PlaceholderAPI: %ocm_gapple_cooldown%
    normal: 0
    # Message when user tries to eat golden apple during cooldown. Leave empty to disable.
    message-normal: "&ePlease wait %seconds%s before eating another golden apple."
    # The cooldown for enchanted golden apples
    # PlaceholderAPI: %ocm_napple_cooldown%
    enchanted: 0
    # Message when user tries to eat enchanted golden apple during cooldown. Leave empty to disable.
    message-enchanted: "&ePlease wait %seconds%s before eating another enchanted golden apple."
    # Whether the two apple types share a cooldown.
    # If this is true:
    #   1. Eating any apple resets both cooldowns
    #   2. Each apple type can only be eaten when its cooldown time is over
    #      This means that when you eat *any* apple you start two parallel cooldowns: One for enchanted and one
    #      for normal apples. Each type can only be eaten when its cooldown is over.
    #      Once any apple is eaten, both cooldowns are restarted, so you can not eat either type again
    #      before its full cooldown is over.
    #   3. To have the plugin treat normal and enchanted golden apples as having the same cooldown,
    #      then set the same cooldown time and enable shared mode. (This was the old mode)
    # If this is false:
    #   Eating an enchanted apple will prevent any *enchanted* apple type from being eaten before the cooldown is over
    #   Eating a normal apple will prevent any *normal* apple type from being eaten before the normal cooldown is over
    is-shared: false
  # If you want to allow enchanted golden apple crafting
  enchanted-golden-apple-crafting: false
  # Enabling this makes the potion effects gained by eating golden apples
  # and enchanted golden apples the same as it was in pre-1.9
  old-potion-effects: false
  # Potion effects golden apples should apply
  # Duration is in ticks (20 ticks = 1 second)
  # Amplifier is the potion level - 1, so Regeneration IV would be amplifier 3
  gapple-effects:
    regeneration:
      duration: 100
      amplifier: 1
    absorption:
      duration: 2400
      amplifier: 0
  # Potion effects enchanted golden apples should apply
  napple-effects:
    regeneration:
      duration: 600
      amplifier: 4
    damage_resistance:
      duration: 6000
      amplifier: 0
    fire_resistance:
      duration: 6000
      amplifier: 0
    absorption:
      duration: 2400
      amplifier: 0
  # Enable this if you have another plugin which adds a crafting recipe for
  # enchanted golden apples (requires server restart)
  no-conflict-mode: false

old-potion-effects:
  # This is to restore the 1.8 potion effects and duration
  enabled: false

  # DURATION: (in seconds)
  potion-durations:
    regen: # Regeneration
      drinkable:
        base: 45
        II: 22
        extended: 120
      splash:
        base: 33
        II: 16
        extended: 90

    speed: # Swiftness
      drinkable:
        base: 180
        II: 90
        extended: 480
      splash:
        base: 135
        II: 67
        extended: 360

    fire_resistance:
      drinkable:
        base: 180
        extended: 480
      splash:
        base: 135
        extended: 360

    poison:
      drinkable:
        base: 45
        II: 22
        extended: 120
      splash:
        base: 33
        II: 16
        extended: 90

    night_vision:
      drinkable:
        base: 180
        extended: 480
      splash:
        base: 180
        extended: 480

    weakness:
      drinkable:
        base: 90
        extended: 240
      splash:
        base: 90
        extended: 240

    strength:
      drinkable:
        base: 180
        II: 90
        extended: 480
      splash:
        base: 135
        II: 67
        extended: 360

    slowness:
      drinkable:
        base: 90
        extended: 240
      splash:
        base: 67
        extended: 180

    jump: # Leaping
      drinkable:
        base: 180
        II: 90
        extended: 480
      splash:
        base: 135
        II: 67
        extended: 360

    water_breathing:
      drinkable:
        base: 180
        extended: 480
      splash:
        base: 135
        extended: 360

    invisibility:
      drinkable:
        base: 180
        extended: 480
      splash:
        base: 135
        extended: 360

    # 1.9+ potions
    # Turtle Master potion currently incompatible, will just work like default
    luck:
      drinkable:
        base: 300
      splash:
        base: 300

    slow_falling:
      drinkable:
        base: 90
        extended: 240
      splash:
        base: 90
        extended: 240

  # EFFECTS
  # If 'multiplier' is true value is multiplied by base tool damage. If 'addend' it is added.
  # If both true, it is first increased by 1 then multiplied (same as +xx%)
  # Strength potion
  # 1.9: I = +3; II = +6;    1.8: I = +130%; II = +260%
  strength:
    modifier: 1.3
    multiplier: true
    addend: true
  # Weakness potion
  # 1.9 value: -4   1.8 value: -0.5
  weakness:
    modifier: -0.5
    multiplier: false

# ########################
# MISCELLANEOUS
# ########################

disable-crafting:
  # Disable the crafting of specified items
  enabled: false
  # List of denied items
  denied:
    - shield
  # Show the user a message if they try to craft a blacklisted item
  showMessage: true
  message: "&cYou cannot craft that item!"

disable-offhand:
  # Disable the usage of the offhand
  # Won't affect sword-blocking module
  enabled: false
  # Whether the following list allows items or blocks them
  whitelist: true
  # List of items that should be allowed/blocked
  # Example: [diamond_sword,BOW]
  items: [ ]
  # Message to send user when denied. Set to '' to disable
  denied-message: "&cOff-hand is disabled"

old-brewing-stand:
  # Automatically refuels brewing stands
  enabled: false

no-lapis-enchantments:
  # Automatically adds lapis to enchantment tables upon opening
  enabled: false
  # Whether to only allow this for players with oldcombatmechanics.nolapis permission
  usePermission: false

disable-elytra:
  # Do not allow players to wear elytra
  enabled: false

disable-enderpearl-cooldown:
  # Disables enderpearl cooldown
  enabled: false
  # The cooldown, in seconds
  # PlaceholderAPI: %ocm_enderpearl_cooldown%
  cooldown: 0
  # Show the user a message if they try to use an enderpearl and the cooldown has not expired yet
  showMessage: true
  message: "&cYou must wait &7%ds&c before using an enderpearl again!"

chorus-fruit:
  # This makes the chorus fruit behaviour configurable
  enabled: false
  # The maximum distance the fruit can teleport the player. This a PER AXIS value, so this outlines a cube with
  # 2 * max-teleportation-distance as the side length
  # Vanilla default is 8.
  # Setting this to 0 disables chorus fruit teleport.
  # Setting this to a value greater than 8 MIGHT CAUSE CONFLICTS with bukkit's internal anti cheat
  # and *potentially* any other anti-cheat you use. Please make sure this is not an issue before increasing
  # this value.
  max-teleportation-distance: 8
  # Whether to prevent eating the fruit completely. This also prevents the teleportation.
  prevent-eating: false
  # The saturation value of the chorus fruit.
  # Vanilla default is 2.4
  saturation-value: 2.4
  # The hunger value of the chorus fruit.
  # Vanilla default is 4 (2 bars)
  hunger-value: 4

old-burn-delay:
  # This makes it so entities will immediately start to burn when entering fire
  enabled: false
  # How long, in ticks, entities should be on fire for after not being in direct contact anymore
  fire-ticks: 120

disable-projectile-randomness:
  # This is to remove projectile randomness while firing arrows with a bow
  # Or to remove effects of velocity when player is running and launching potions etc
  # This is actually a very old feature and has been in the game for quite some time
  enabled: false
  # What projectiles are affected e.g. arrow, splash_potion, snowball, egg, fishing_hook
  projectile-types: [ arrow ]
  # This is the threshold between projectiles' (X,Z) values before they're considered the same and straightened
  # This value is only useful for multishot. The default of 0.1 works at all but extremely shallow angles,
  # where arrows end up bunched together. Set to 1 if you want multishots to all follow the same path.
  epsilon: 0.1

disable-bow-boost:
  # This is to stop players from boosting themselves forward by hitting themselves
  # while running with a punch II arrow from their bow
  # This module simply stops them from hitting themselves with arrows entirely
  enabled: false

disable-attack-sounds:
  # Disables attack sounds that were added with 1.9+
  # Requires ProtocolLib
  enabled: false
  # The sounds that will be blocked by this module
  blocked-sound-names:
    - "ENTITY_PLAYER_ATTACK_STRONG"
    - "ENTITY_PLAYER_ATTACK_SWEEP"
    - "ENTITY_PLAYER_ATTACK_NODAMAGE"
    - "ENTITY_PLAYER_ATTACK_KNOCKBACK"
    - "ENTITY_PLAYER_ATTACK_CRIT"
    - "ENTITY_PLAYER_ATTACK_WEAK"

disable-player-collisions:
  # This is to disable player collisions
  # This is compatible with most scoreboard and tablist-editing plugins
  enabled: false

# ########################
# SPECIAL SETTINGS BELOW #
# ########################

message-prefix: "&6[OCM]&r"

# This is to toggle the update checker
update-checker:
  # Whether to check for updates and notify players with the oldcombatmechanics.notify permission
  enabled: true
  # Whether to automatically download an update of the plugin
  # The update is applied on the next restart/reload of the server
  # Auto update is disabled if Spigot version is below 1.18.1 and force-below-1-18-1-config-upgrade is false
  # This is to prevent accidentally resetting the config
  auto-update: true

# Whether to force config upgrade even in Spigot versions below 1.18.1
# This is not advised, as all the comments would be removed
force-below-1-18-1-config-upgrade: false

# This enables command argument completion when pressing tab
command-completer:
  enabled: true

# This enables debug messages, only enable when troubleshooting
debug:
  enabled: false

# DO NOT CHANGE THIS NUMBER AS IT WILL RESET YOUR CONFIG
config-version: 63

debug
[16:18:33] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:33] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:33] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:33] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:33] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:33] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:33] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:33] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:33] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:33] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:33] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:33] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:33] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:33] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:34] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:34] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:35] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:35] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:35] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:35] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:35] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:35] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:35] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:35] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:35] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:35] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:35] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:35] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:35] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:35] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:36] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:36] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 15.0
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 15.0
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 12.0
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] 1.8 Critical hit detected
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] 1.9 Critical hit detected
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:37] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:37] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 19.75
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 15.0
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 15.0
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 12.0
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] 1.8 Critical hit detected
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] 1.9 Critical hit detected
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 19.75
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:38] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:38] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:39] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:39] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:40] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:40] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 15.0
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 15.0
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 12.0
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] 1.8 Critical hit detected
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] 1.9 Critical hit detected
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:41] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:41] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 19.75
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 15.0
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 15.0
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 12.0
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] 1.8 Critical hit detected
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] 1.9 Critical hit detected
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 19.75
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 15.0
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 15.0
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 12.0
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] 1.8 Critical hit detected
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] 1.9 Critical hit detected
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:42] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:42] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 19.75
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:43] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:43] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:44] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:44] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:44] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:44] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:44] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:44] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:44] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:44] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:44] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:44] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:44] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:44] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:44] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:44] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:18:45] [Render thread/INFO]: [CHAT] [Debug] Raw attack damage: 11.0
[16:18:45] [Render thread/INFO]: [CHAT] [Debug] Without overdamage: 11.0
[16:18:45] [Render thread/INFO]: [CHAT] [Debug] Mob: 0.0 Sharpness: 3.0
[16:18:45] [Render thread/INFO]: [CHAT] [Debug] No ench damage: 8.0
[16:18:45] [Render thread/INFO]: [CHAT] [Debug] Strength Modifier: 0.0
[16:18:45] [Render thread/INFO]: [CHAT] [Debug] Weakness Modifier: 0.0
[16:18:45] [Render thread/INFO]: [CHAT] [Debug] Base tool damage: 8.0
[16:18:45] [Render thread/INFO]: [CHAT] [DEBUG][ModuleOldToolDamage] Old sharpness damage: 3.0 New: 6.25
[16:18:45] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Base: 9.0
[16:18:45] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Weak: 0.0
[16:18:45] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength level: 0
[16:18:45] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Strength: 0.0
[16:18:45] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] Mob 0.0 Sharp: 6.25 Scaled: 6.25
[16:18:45] [Render thread/INFO]: [CHAT] [DEBUG][EntityDamageByEntityListener] New Damage: 15.25
[16:19:37] [Render thread/INFO]: [CHAT] [DEBUG][ModuleAttackFrequency] Set hit delay to 20

@kernitus
Copy link
Owner

I clicked the link provided, so it would have been ver 215, server is running paper 1.20.4-436.
config.yml
debug

Can you capture the debug output from the console? The debug you posted is missing all the calculations from the modules - most importantly the old armour strength module. Also, please don't use hastebin because the pastes get deleted too quickly

@mitellius
Copy link

mitellius commented Apr 1, 2024

Also clicked on the link provided ver 215, git-purpur-1985 (MC: 1.19.4)

Gyazo gif:
https://gyazo.com/28155116a447e8921bffafbffa54e36a

Debug output crit (With Fire):
debug_crit.txt

Gyazo gif:
https://gyazo.com/3a54e76296772547dde56e13bd7e7977

Debug output no crit (With Fire):
debug_nocrit.txt

Sharpness 5 (Without fire)
https://gyazo.com/ef51e37f44c0f4218228ebf423eccc3c
sword_withoutfire.txt

Config:
config.txt

Gear:

Protection 4 and unbreaking 3
Sword: Sharpness 5 and fire aspect 2 and the other sword Sharpness 5 and unbreaking 3

Would say that the issue still persists, so now and then there comes in a lot of damage out of nowhere.

@mitellius
Copy link

Do you need more information?

@JustinSpoor

This comment was marked as spam.

@USBCharger
Copy link

Sorry for not replying for a while, I should (hopefully) have the information later today, I've been away from doing server administration stuff for a bit.

@USBCharger
Copy link

Sorry for taking so long. Upon farther inspection, I realized my initial test was completely flawed, due to it being carried out in an area of world where another plugin was also playing with player damages, and reducing it (inside of a kingdomsx claim, I forgot that there was a damage reducer upgrade)

There is still an issue with fire tick, which may have been what mitellius was referring to when he said "Would say that the issue still persists, so now and then there comes in a lot of damage out of nowhere."

Here are the logs of my testing, from console, and also a video showing how fire damage alone is out of whack with OCM, in contrast to the vanilla experience on a (basically vanilla) 1.20.4 server.

30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldToolDamage] Weapon material: NETHERITE_SWORD 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] Old tool damage: 8.0 New: 9.0 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Base: 9.0 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Weak: 0.0 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Strength level: 0 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Strength: 0.0 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Scale by attack delay: 9.0 *= 0.2 + 1.0^2 * 0.8 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Crit 9.0 *= 1.0 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Scale enchantments by attack delay: 6.25 *= 1.0 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 15.25 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BASE: 15.25 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BLOCKING: -0.0 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR: -12.200000000000001 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] RESISTANCE: -0.0 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR ENCHS: -2.4399999999999995 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ABSORPTION: -0.0 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] Final damage after defence calc: 0.6099999999999994 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: ENTITY_ATTACK 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Set last damage to 0 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Set last damage back to 15.25 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Was fake overdamage, cancelling 1.0 <= 15.25 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 1.0 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: FIRE_TICK 30.04 21:45:51 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Non-entity damage, using default last damage 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldToolDamage] Weapon material: NETHERITE_SWORD 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] Old tool damage: 8.0 New: 9.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Base: 9.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Weak: 0.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Strength level: 0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Strength: 0.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Scale by attack delay: 9.0 *= 0.2 + 1.0^2 * 0.8 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Crit 9.0 *= 1.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Scale enchantments by attack delay: 6.25 *= 1.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 15.25 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BASE: 15.25 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BLOCKING: -0.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR: -12.200000000000001 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] RESISTANCE: -0.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR ENCHS: -2.4399999999999995 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ABSORPTION: -0.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] Final damage after defence calc: 0.6099999999999994 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: ENTITY_ATTACK 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Set last damage to 0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Set last damage back to 15.25 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Was fake overdamage, cancelling 1.0 <= 15.25 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 1.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: FIRE_TICK 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Non-entity damage, using default last damage 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldToolDamage] Weapon material: NETHERITE_SWORD 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] Old tool damage: 8.0 New: 9.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Base: 9.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Weak: 0.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Strength level: 0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Strength: 0.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Scale by attack delay: 9.0 *= 0.2 + 1.0^2 * 0.8 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Crit 9.0 *= 1.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Scale enchantments by attack delay: 6.25 *= 1.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 15.25 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BASE: 15.25 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BLOCKING: -0.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR: -12.200000000000001 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] RESISTANCE: -0.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR ENCHS: -2.4399999999999995 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ABSORPTION: -0.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] Final damage after defence calc: 0.6099999999999994 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: ENTITY_ATTACK 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Set last damage to 0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Set last damage back to 15.25 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Was fake overdamage, cancelling 1.0 <= 15.25 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 1.0 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: FIRE_TICK 30.04 21:45:52 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Non-entity damage, using default last damage 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldToolDamage] Weapon material: NETHERITE_SWORD 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] Old tool damage: 8.0 New: 9.0 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Base: 9.0 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Weak: 0.0 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Strength level: 0 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Strength: 0.0 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Scale by attack delay: 9.0 *= 0.2 + 1.0^2 * 0.8 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Crit 9.0 *= 1.0 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Scale enchantments by attack delay: 6.25 *= 1.0 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 15.25 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BASE: 15.25 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BLOCKING: -0.0 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR: -12.200000000000001 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] RESISTANCE: -0.0 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR ENCHS: -2.4399999999999995 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ABSORPTION: -0.0 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] Final damage after defence calc: 0.6099999999999994 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: ENTITY_ATTACK 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Set last damage to 0 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Set last damage back to 15.25 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Was fake overdamage, cancelling 1.0 <= 15.25 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 1.0 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: FIRE_TICK 30.04 21:45:53 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Non-entity damage, using default last damage 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldToolDamage] Weapon material: NETHERITE_SWORD 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] Old tool damage: 8.0 New: 9.0 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Base: 9.0 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Weak: 0.0 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Strength level: 0 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Strength: 0.0 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Scale by attack delay: 9.0 *= 0.2 + 1.0^2 * 0.8 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Crit 9.0 *= 1.0 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Scale enchantments by attack delay: 6.25 *= 1.0 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 15.25 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BASE: 15.25 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BLOCKING: -0.0 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR: -12.200000000000001 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] RESISTANCE: -0.0 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR ENCHS: -2.4399999999999995 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ABSORPTION: -0.0 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] Final damage after defence calc: 0.6099999999999994 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: ENTITY_ATTACK 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Set last damage to 0 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Set last damage back to 15.25 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Was fake overdamage, cancelling 1.0 <= 15.25 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 1.0 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: FIRE_TICK 30.04 21:45:54 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Non-entity damage, using default last damage 30.04 21:45:55 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 1.0 30.04 21:45:55 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BASE: 1.0 30.04 21:45:55 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BLOCKING: -0.0 30.04 21:45:55 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR: 0.0 30.04 21:45:55 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] RESISTANCE: -0.0 30.04 21:45:55 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR ENCHS: -0.0 30.04 21:45:55 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ABSORPTION: -0.0 30.04 21:45:55 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] Final damage after defence calc: 1.0 30.04 21:45:55 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: FIRE_TICK 30.04 21:45:55 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Non-entity damage, using default last damage 30.04 21:45:56 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 1.0 30.04 21:45:56 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BASE: 1.0 30.04 21:45:56 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BLOCKING: -0.0 30.04 21:45:56 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR: 0.0 30.04 21:45:56 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] RESISTANCE: -0.0 30.04 21:45:56 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR ENCHS: -0.0 30.04 21:45:56 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ABSORPTION: -0.0 30.04 21:45:56 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] Final damage after defence calc: 1.0 30.04 21:45:56 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: FIRE_TICK 30.04 21:45:56 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Non-entity damage, using default last damage 30.04 21:45:57 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 1.0 30.04 21:45:57 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BASE: 1.0 30.04 21:45:57 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BLOCKING: -0.0 30.04 21:45:57 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR: 0.0 30.04 21:45:57 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] RESISTANCE: -0.0 30.04 21:45:57 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR ENCHS: -0.0 30.04 21:45:57 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ABSORPTION: -0.0 30.04 21:45:57 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] Final damage after defence calc: 1.0 30.04 21:45:57 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: FIRE_TICK 30.04 21:45:57 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Non-entity damage, using default last damage 30.04 21:45:58 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 1.0 30.04 21:45:58 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BASE: 1.0 30.04 21:45:58 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BLOCKING: -0.0 30.04 21:45:58 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR: 0.0 30.04 21:45:58 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] RESISTANCE: -0.0 30.04 21:45:58 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR ENCHS: -0.0 30.04 21:45:58 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ABSORPTION: -0.0 30.04 21:45:58 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] Final damage after defence calc: 1.0 30.04 21:45:58 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: FIRE_TICK 30.04 21:45:58 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Non-entity damage, using default last damage 30.04 21:45:59 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 1.0 30.04 21:45:59 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BASE: 1.0 30.04 21:45:59 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BLOCKING: -0.0 30.04 21:45:59 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR: 0.0 30.04 21:45:59 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] RESISTANCE: -0.0 30.04 21:45:59 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR ENCHS: -0.0 30.04 21:45:59 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ABSORPTION: -0.0 30.04 21:45:59 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] Final damage after defence calc: 1.0 30.04 21:45:59 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: FIRE_TICK 30.04 21:45:59 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Non-entity damage, using default last damage 30.04 21:46:00 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 1.0 30.04 21:46:00 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BASE: 1.0 30.04 21:46:00 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BLOCKING: -0.0 30.04 21:46:00 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR: 0.0 30.04 21:46:00 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] RESISTANCE: -0.0 30.04 21:46:00 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR ENCHS: -0.0 30.04 21:46:00 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ABSORPTION: -0.0 30.04 21:46:00 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] Final damage after defence calc: 1.0 30.04 21:46:00 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: FIRE_TICK 30.04 21:46:00 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Non-entity damage, using default last damage 30.04 21:46:00 [Multicraft] Server already running 30.04 21:46:00 [Multicraft] Server ran command Start 30.04 21:46:01 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Attack damage (before defence): 1.0 30.04 21:46:01 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BASE: 1.0 30.04 21:46:01 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] BLOCKING: -0.0 30.04 21:46:01 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR: 0.0 30.04 21:46:01 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] RESISTANCE: -0.0 30.04 21:46:01 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ARMOUR ENCHS: -0.0 30.04 21:46:01 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] ABSORPTION: -0.0 30.04 21:46:01 [Server] INFO [OldCombatMechanics] [DEBUG] [ModuleOldArmourStrength] Final damage after defence calc: 1.0 30.04 21:46:01 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] monitor DAMAGE to GalacticRealms CAUSE: FIRE_TICK 30.04 21:46:01 [Server] INFO [OldCombatMechanics] [DEBUG] [EntityDamageByEntityListener] Non-entity damage, using default last damage

Video / / /
https://github.com/kernitus/BukkitOldCombatMechanics/assets/43736233/c6c5e80f-a91b-49ee-b1f1-63de70136f5d

Summery: Dmg of between .3 to .4 in vanilla, 1 with OCM.

@kernitus
Copy link
Owner

@USBCharger are you able to explain a very basic example to reproduce the issue with as few variables as possible? e.g. no armour/enchantments etc.

@USBCharger
Copy link

Could you rephrase that please @kernitus? I think I have an idea what you're saying but I'm not sure I fully understand.

@kernitus
Copy link
Owner

kernitus commented May 1, 2024

Could you rephrase that please @kernitus? I think I have an idea what you're saying but I'm not sure I fully understand.

I need you to outline a minimal reproducible example, so that we can isolate the problem and figure out where it's coming from. That is, the fewest steps/setup that will cause the issue to show up.

@mitellius
Copy link

mitellius commented May 1, 2024

Could you rephrase that please @kernitus? I think I have an idea what you're saying but I'm not sure I fully understand.

I need you to outline a minimal reproducible example, so that we can isolate the problem and figure out where it's coming from. That is, the fewest steps/setup that will cause the issue to show up.

Can I be of any assistance in delivering any test data you need?

@USBCharger
Copy link

@kernitus fire up a server with OCM, and set a player on fire, (the server I have it on is on is 1.20.4) and watch the afterburn firetick do 1 heart of damage. Take OCM off the server, watch the player take .3 or .4 damage per fire tick.

@kernitus
Copy link
Owner

kernitus commented May 2, 2024

@kernitus fire up a server with OCM, and set a player on fire, (the server I have it on is on is 1.20.4) and watch the afterburn firetick do 1 heart of damage. Take OCM off the server, watch the player take .3 or .4 damage per fire tick.

Is this only with fire aspect, or also flint/environmental fire?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting testing The fix to the issue has yet to be tested by the user bug This is a confirmed bug
Projects
None yet
Development

No branches or pull requests

9 participants