Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type for setConfig #8

Open
relaxxpls opened this issue Mar 17, 2024 · 0 comments
Open

Incorrect type for setConfig #8

relaxxpls opened this issue Mar 17, 2024 · 0 comments

Comments

@relaxxpls
Copy link

relaxxpls commented Mar 17, 2024

type SetConfig = (
headers: DownloadHeaders,
progressInterval: number,
isLogsEnabled: boolean
) => void;

doesn't match

export function setConfig ({ headers, progressInterval, isLogsEnabled }) {

I believe it should instead be:

export interface Config {
  headers?: DownloadHeaders;
  progressInterval: number : null;
  isLogsEnabled?: boolean;
}

type SetConfig = (config: Config) => void;

Please update it 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant