Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-open tab in other container: no longer effective #38

Closed
grahamperrin opened this issue Sep 18, 2017 · 9 comments
Closed

re-open tab in other container: no longer effective #38

grahamperrin opened this issue Sep 18, 2017 · 9 comments

Comments

@grahamperrin
Copy link
Contributor

Issue observed with 0.0.32, 0.0.33 and 0.0.34.

Also (echoes of recently closed reopen tab in other … default: does not work for contained tabs · Issue #36 · kesselborn/taborama):

  • if Taborama is enabled
  • and if Context Plus is used to re-open in another container
  • then Context Plus can not reopen the tab to the default context.
@kesselborn
Copy link
Owner

this is true if tab moving is enabled in taborama which basically implements the functionality of "Context Plus". If tab moving is disabled, "Context Plus" works as expected.
I don't really see the value of running "Context Plus" and taborama with tab movement enabled in parallel and therefore am reluctant to complicate the code in order to fix this problem.
However: thanks for the report, very much appreciated.

@grahamperrin
Copy link
Contributor Author

Sorry, there's some misunderstanding. Please reopen this issue.

With Taborama alone:

re-open tab in other container: no longer effective

Reproducible with 0.0.38 on (unsupported) Firefox 55.0.3. I'll retest with 57.x.


The mention of the side-effect, on Context Plus, was to maybe help understand a cause of this issue.

@grahamperrin
Copy link
Contributor Author

Reproduced with Taborama 0.0.38 alone on Firefox Nightly 57.0a1 (2017-09-16) (64-bit) on Kubuntu.

@kesselborn
Copy link
Owner

mmm ... it works here with Nightly. What exactly is the problem? Changing from a container to the default container?

@grahamperrin
Copy link
Contributor Author

When a container is clicked, it appears to be selected, then nothing more happens.

Here's a screen recording of the symptom with 55.0.3 on FreeBSD-CURRENT. The symptom is the same with Nightly on Kubuntu.

2017-09-20 19:01:52.mp4.zip

@kesselborn
Copy link
Owner

ha ... thanks a lot for your efforts -- even a movie.
I am stupid 😄 : I am a keyboard person and never even tested it with the mouse ... so: you are right of course but it works with the keyboard which is why I did not see the problem.

@kesselborn
Copy link
Owner

just released v0.0.39 which should fix the problem ... thanks again

@grahamperrin
Copy link
Contributor Author

Fix confirmed. Tested: Taborama 0.0.44 with Firefox 55.0.3 on FreeBSD-CURRENT.

@grahamperrin
Copy link
Contributor Author

@kesselborn kesselborn added this to Next up in kesselborn/conex Apr 2, 2019
@kesselborn kesselborn moved this from Next up to Done in kesselborn/conex Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants