Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching using integer values causes error #3

Closed
azuraji opened this issue Nov 21, 2022 · 4 comments
Closed

Searching using integer values causes error #3

azuraji opened this issue Nov 21, 2022 · 4 comments

Comments

@azuraji
Copy link

azuraji commented Nov 21, 2022

Not sure if it's supported or not (but would be nice); I'd like to search using an integer value, e.g. the TextureID of an icon.

This gives me a LUA error though:

7x ...rgerMacroIconSelection/Mainline/IconDataProvider.lua:31: attempt to concatenate local 'texture' (a nil value)
[string "@LargerMacroIconSelection/Mainline/IconDataProvider.lua"]:31: in function <...rgerMacroIconSelection/Mainline/IconDataProvider.lua:25>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "@LargerMacroIconSelection/Mainline/LargerMacroIconSelection.lua"]:83: in function <...oIconSelection/Mainline/LargerMacroIconSelection.lua:80>

image

@Ketho
Copy link
Member

Ketho commented Nov 21, 2022

I suppose you mean searching by index instead of a FileID/TextureID. That's not supported since the index for a specific icon can be different between each class and the macro / equipment manager.

It does support searching by FileID though.

image

image

@azuraji
Copy link
Author

azuraji commented Nov 21, 2022

Strange, it was actually indeed FileID/TextureID (not index) I was referring to, but when typing in any numerical values, I'm getting the above error.

UPDATE: It seems to be working for me now.

@azuraji
Copy link
Author

azuraji commented Nov 21, 2022

I think I was able to reproduce it.

  1. First I search for a string, e.g. "legion".
  2. Then I make a numeric search, e.g. "333".
  3. Then I scroll the frame and the error occurs.

@Ketho
Copy link
Member

Ketho commented Nov 21, 2022

Oh thanks for the error report and steps to reproduce, I will look at it

@Ketho Ketho closed this as completed in e7e9ded Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants