Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance integration tests to check for "grid-area" and area position #27

Closed
kettanaito opened this issue Jun 19, 2018 · 1 comment
Closed

Enhance integration tests to check for "grid-area" and area position #27

kettanaito opened this issue Jun 19, 2018 · 1 comment
Assignees
@kettanaito
Labels
enhancement New feature or request

Comments

@kettanaito
Copy link
Owner

What

Need to enhance integration tests assertion to also test for grid-area property value and area component position on the screen.

Why

When grid-area assignment is broken, grid areas will still be visible, but positioned in the unexpected part of the layout. That is a falsy positive test result, which must be avoided.

How

  1. Enhance the assertion function.
@kettanaito kettanaito added the enhancement New feature or request label Jun 19, 2018
@kettanaito kettanaito mentioned this issue Jun 19, 2018
Merged
@kettanaito kettanaito self-assigned this Jun 19, 2018
@kettanaito
Copy link
Owner Author

Proper grid area value check is implemented using .haveArea() custom Cypress command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kettanaito kettanaito

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kettanaito