Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "." (dot) as the grid area name #5

Closed
kettanaito opened this issue May 29, 2018 · 2 comments
Closed

Handle "." (dot) as the grid area name #5

kettanaito opened this issue May 29, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good place to start for newcomers needs:discussion Further information is requested
Milestone

Comments

@kettanaito
Copy link
Owner

kettanaito commented May 29, 2018

What

Need to handle . character which is supported by CSS Grid spec.

Why

In order to cover feature which is in spec, in case it needs to be handled from React side.

How

  1. Refine what dot stands for in grid-template-areas. There is a fair chance that we need not to handle it in any way. If that is a placeholder to achieve different gutter (gap) between different grid areas, this can be done via explicit spacing props (margin/padding) assigned directly to area components as props.
  2. If it's a placeholder, it can be handled by rendering a <Placeholder/> component at its place.
@kettanaito kettanaito added enhancement New feature or request good first issue Good place to start for newcomers labels May 30, 2018
@kettanaito
Copy link
Owner Author

It seems that dot is there to create an empty row/column to achieve uneven gutter (gap).

If it's so indeed, the same result can be achieved using padding/margin properties applied to specific grid areas, no need to handle that on the template level. But I would like to make sure I understand the dot's behavior properly.

@kettanaito kettanaito added needs:discussion Further information is requested and removed good first issue Good place to start for newcomers labels Jun 17, 2018
@kettanaito kettanaito added this to the Core milestone Jun 17, 2018
@kettanaito kettanaito added the good first issue Good place to start for newcomers label Jun 20, 2018
@kettanaito kettanaito self-assigned this Jul 24, 2018
@kettanaito
Copy link
Owner Author

Verified as a part of #56. Citing:

Period (.) seems to be handled properly.
In case unexpected behavior is encountered, a respective issue should be created.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good place to start for newcomers needs:discussion Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant