Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flexbox an explicit behavior on Box #71

Closed
kettanaito opened this issue Oct 7, 2018 · 2 comments
Closed

Make flexbox an explicit behavior on Box #71

kettanaito opened this issue Oct 7, 2018 · 2 comments
Labels
bug needs:discussion Further information is requested
Milestone

Comments

@kettanaito
Copy link
Owner

Why

Enforcing all area components behave like flex results into broken layouts by default.

Environment

  • atomic-layout version: 0.3.8

Expected behavior

Flex behavior doesn't interfere with the existing layouts.

How

  1. Turn off flexbox display by default, make it parametric with the explicit prop (i.e. flex).
  2. Set flex-direction: column by default. However, this, most likely, will not eliminate the issue.
@kettanaito kettanaito added this to the 1.0 milestone Oct 7, 2018
@kettanaito kettanaito self-assigned this Oct 7, 2018
@kettanaito
Copy link
Owner Author

kettanaito commented Oct 7, 2018

Implemented and released under 0.3.9.

I would keep this issue open, since I feel there can be a better way of handling flexbox.

@kettanaito kettanaito added needs:discussion Further information is requested and removed CRUCIAL labels Oct 7, 2018
@kettanaito kettanaito removed their assignment Jan 7, 2019
@kettanaito
Copy link
Owner Author

kettanaito commented Feb 26, 2019

So far the usage of the Flexbox display model seems transparent and comfortable. Closing.

import { Box } from 'atomic-layout'

const Header = () => (
  <Box flex alignItems="center" justifyContent="end">
    {/* ... */}
  </Box>
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs:discussion Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant