Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested field groups #223

Closed
kettanaito opened this issue Mar 20, 2018 · 2 comments
Closed

Nested field groups #223

kettanaito opened this issue Mar 20, 2018 · 2 comments
Assignees
@kettanaito
Labels
enhancement Enhances existing functionality. good first issue Good for newcomers.
Projects
Roadmap
Milestone
1.x

Comments

@kettanaito
Copy link
Owner

What

I suggest to add support for nested field groups.

Why

  1. It's good when field group behaves the same no matter if you nest/split it.
  2. It shouldn't be a dramatic change in the Field.Group component.

How

  1. Extend the expected contextTypes in Field.Group to accept another field group name.
  2. Accumulate gathered field group names into an array and pass it down the context.
  3. Write tests to ensure nested groups register and serialize properly.
@kettanaito kettanaito added the enhancement Enhances existing functionality. label Mar 20, 2018
@kettanaito kettanaito added this to the Release 2.0 milestone Mar 20, 2018
@kettanaito kettanaito added this to In scope in Roadmap Mar 20, 2018
@kettanaito kettanaito added the good first issue Good for newcomers. label Mar 20, 2018
@kettanaito kettanaito self-assigned this Mar 21, 2018
@kettanaito kettanaito moved this from In scope to In progress in Roadmap Mar 21, 2018
@kettanaito kettanaito moved this from In progress to Ready for release in Roadmap Mar 21, 2018
@kettanaito
Copy link
Owner Author

Implemented.

Ready to be merged and published under the next minor release. I would wait to ensure 1.0.1 doesn't have any crucial bugs to fix, and then create the next minor release to include this feature.

@kettanaito kettanaito mentioned this issue Mar 21, 2018
Merged
@kettanaito kettanaito modified the milestones: 2.0, 1.x.x Mar 23, 2018
@kettanaito
Copy link
Owner Author

Merged.

Ready to be published in 1.1.0 after all the known bugs are fixed.

Roadmap automation moved this from Ready for release to Released Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kettanaito kettanaito

Labels
enhancement Enhances existing functionality. good first issue Good for newcomers.
Projects
Roadmap
  
Released
Milestone
1.x
Development

No branches or pull requests
1 participant
@kettanaito