Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle size reduction roadmap #253

Open
3 of 7 tasks
kettanaito opened this issue May 21, 2018 · 4 comments
Open
3 of 7 tasks

Bundle size reduction roadmap #253

kettanaito opened this issue May 21, 2018 · 4 comments
Labels
CRITICAL enhancement Enhances existing functionality.
Milestone

Comments

@kettanaito
Copy link
Owner

kettanaito commented May 21, 2018

Roadmap

Bundling

  • Double check that tree shaking is working properly
  • Ensure Flow types are stripped in the production bundle
  • Ensure Ramda methods are imported explicitly, without unnecessary code
  • Ensure any kind of useless comments are stripped out in the production bundle

Architecture

@kettanaito kettanaito added enhancement Enhances existing functionality. CRITICAL labels May 21, 2018
@kettanaito kettanaito added this to the 1.x.x milestone May 21, 2018
@Vidlec
Copy link
Collaborator

Vidlec commented Jun 29, 2018

Regarding Ramdas ifElse: https://github.com/ramda/ramda/blob/v0.25.0/source/ifElse.js
Not sure if it can be made significantly smaler. Also thats only 1.3kb not minified

@kettanaito
Copy link
Owner Author

@Vidlec I've tried replacing Ramda's method with identical one, except those don't have currying, and in average they are at least half smaller the size of the original Ramda methods.

That is, of course, subjective, but I've put it there to be considered.

@kettanaito
Copy link
Owner Author

@Vidlec, after some time I also came to conclusion that micro-optimization is not worth it. I would stick with Ramda's functions.

@kettanaito kettanaito mentioned this issue Sep 27, 2018
Merged
3 tasks
@kettanaito
Copy link
Owner Author

Proper imports of ramda (or the usage of babel-pluing-ramda) reduces the library's bundle size by ~50Kb.

@kettanaito kettanaito modified the milestones: 1.x, Optimization Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CRITICAL enhancement Enhances existing functionality.
Projects
None yet
Development

No branches or pull requests

2 participants