Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field.Group: Support "exact" prop #321

Closed
kettanaito opened this issue Nov 2, 2018 · 1 comment
Closed

Field.Group: Support "exact" prop #321

kettanaito opened this issue Nov 2, 2018 · 1 comment
Assignees
Labels
enhancement Enhances existing functionality. good first issue Good for newcomers. tests
Projects
Milestone

Comments

@kettanaito
Copy link
Owner

What

I suggest to add a new exact prop to the <Field.Group/> component.

Why

To prevent groups closing/reopening for nested group that must belong to the group outside.

Example

<Field.Group name="first">
  <Field.Group name="second">
    <Input name="fieldOne" initialValue="foo" />
  </Field.Group>

  <Field.Group exact name="second">
    <Input name="fieldOne" initialValue="bar" />
  </Field.Group>
</Field.Group>

Serializes into:

{
  "first": {
    "second": {
      "fieldOne": "foo"
    }
  },
  "second": { // exact
    "fieldOne": "bar"
  }
}
@kettanaito kettanaito added enhancement Enhances existing functionality. tests labels Nov 2, 2018
@kettanaito kettanaito added this to the 1.x milestone Nov 2, 2018
@kettanaito kettanaito added the good first issue Good for newcomers. label Nov 3, 2018
@kettanaito kettanaito added this to In scope in Roadmap Nov 5, 2018
@kettanaito kettanaito self-assigned this Nov 6, 2018
@kettanaito
Copy link
Owner Author

The support for exact prop is added. The integration tests for Field.Group have been re-written and simplified.

Roadmap automation moved this from In scope to Released Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances existing functionality. good first issue Good for newcomers. tests
Projects
Roadmap
  
Released
Development

No branches or pull requests

1 participant