Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Form.clear()" with predicate removes fields that don't match predicate from the state #333

Closed
kettanaito opened this issue Nov 16, 2018 · 1 comment
Closed

"Form.clear()" with predicate removes fields that don't match predicate from the state #333

kettanaito opened this issue Nov 16, 2018 · 1 comment
Assignees
@kettanaito
Labels
bug CRITICAL needs:testing
Milestone
Bugs

Comments

@kettanaito
Copy link
Owner

Environment

  • react-advanaced-form: 1.5.10

Why

Because R.reject(predicate) will return only the list of those fields that match predicate. And then stitchFields() will only stitch what's returned. And hard update of this.setState({ fields: nextFields }) will not contain the fields that don't match the predicate.
@kettanaito kettanaito added this to the Bugs milestone Nov 16, 2018
@kettanaito kettanaito self-assigned this Nov 16, 2018
@kettanaito kettanaito mentioned this issue Nov 16, 2018
Merged
@kettanaito
Copy link
Owner Author

kettanaito commented Nov 16, 2018 •
edited

Published in 1.5.11, but needs integration tests.

@kettanaito kettanaito mentioned this issue Dec 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kettanaito kettanaito

Labels
bug CRITICAL needs:testing
Projects
None yet
Milestone
Bugs
Development

No branches or pull requests
1 participant
@kettanaito