-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTK and Slaney #24
Comments
Agreed. Implementation wouldn't be a big issue, so would be the API design. PR would be welcome! |
Will work on it. I am going to reimplement how librosa generates the filters in their backend. However, it is done in python and not in C. Also, I will write some tests that compare my implementation to librosa's but do we have a system in place for writing and evaluating tests? |
If you want to use the same test framework as PyTorch, uinittest would be the way to go. To compare the actual outcome of the two implementation, something like |
@VinodS7 Welcome and thanks :)
Would it make a big difference in computation time? |
If there is no policy forbidding us to do so, I'd also prefer pytest.
I think we should make it easy to reproduce most research papers, so (a) we should include these two filterbanks by default and (b) the API should make it easy to add your own. |
Ok let's go with pytest. |
@VinodS7 Hi, we'd love to hear from you if there's been any progress! :) |
Should be easy to add Slaney following librosa https://librosa.github.io/librosa/_modules/librosa/core/time_frequency.html#hz_to_mel? Would just have to add them as options to |
@keunwoochoi Hey. Sorry got caught up is some paper deadlines. I'll have it done by end of next week! |
@VinodS7 Perfect, no problem, no rush. @ksanjeevan is working on Melspectrogram and I'm expecting to merge some update on it soon. It'll become obvious on which part of the code you should be work on. Thanks! :D |
For reproducibility it would be useful to have these two mel filters. These are the two types of filters I have seen the most so correct me if there are other more important types of mel filters.
The text was updated successfully, but these errors were encountered: