Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace parameter 'skip_calculation_min_winding_distance' with 'pcb_track_width' #30

Open
kev-m opened this issue Sep 13, 2023 · 0 comments
Open

Replace parameter 'skip_calculation_min_winding_distance' with 'pcb_track_width' #30

kev-m opened this issue Sep 13, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kev-m
Copy link
Owner

kev-m commented Sep 13, 2023

Currently, in find_minimal_contour_distance.py if skip_calculation_min_winding_distance is True then the pcb_track_width is set to zero.

The function call is expensive.

It may be better to instead directly specify the PCB track width via the command-line parameters (using pcb_track_width) and only calculate the minimum width between contours if pcb_track_width is 0.

Note: This will deviate from the MATLAB implementation.

Affects: parse_input.py, find_minimal_contour_distance.py and all examples.
@kev-m kev-m added enhancement New feature or request good first issue Good for newcomers labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kev-m