Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ristretto driver #20

Merged
merged 1 commit into from Dec 9, 2019
Merged

Conversation

erikdubbelboer
Copy link
Contributor

See: #19

@erikdubbelboer
Copy link
Contributor Author

Now people who don't use DriverRistretto still have to pull in the dependencies. Would it be an idea to move all drivers to their own packages so you can only compile/pull what you actually use?

@kevburnsjr
Copy link
Owner

That's a very common question in this ecosystem.
What dependencies shall we natively support??

As I said before, specifying cache size in bytes rather than entries is a primary challenge.
You've accomplished this without modifying any existing interfaces.

golang-lru and snappy were inclusions of convenience.
Now ristretto is as well.

Anyone using this library is free to challenge the inclusion.
I suspect none will take objection.

We should add an example.

@kevburnsjr kevburnsjr merged commit 65ba8d3 into kevburnsjr:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants