Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You need to include some adapter that implements __karma__.start method! #38

Closed
hpurmann opened this issue Jun 27, 2016 · 6 comments
Closed
Assignees
Labels

Comments

@hpurmann
Copy link

After upgrading karma to 1.1.0, we got the error (Travis Build)

You need to include some adapter that implements __karma__.start method!

I found the problem being this plugin. After removing from the karma config, the tests ran again. To make sinon work without this plugin, I used the configuration mentioned here:

sinonjs/sinon#600 (comment)

@Havunen
Copy link

Havunen commented Jul 1, 2016

Having same issue here after upgrading to Karma 1.1.0

@bankyadam bankyadam added the bug label Jul 13, 2016
@bankyadam bankyadam self-assigned this Jul 13, 2016
@bankyadam
Copy link
Collaborator

Hi, issue had been fixed in v1.2.3

Please upgrade and check it, thanks!

@callmevlad
Copy link

@adambrunner I'm still seeing this issue with v1.2.3 with:

  • karma@1.1.1
  • karma-chai@0.1.0
  • karma-sinon@1.0.5
  • karma-sinon-chai@1.2.3
  • sinon@1.17.4
  • sinon-chai@2.8.0

Any ideas?

@hpurmann
Copy link
Author

@callmevlad It's most likely one of the other plugins. Please try to create a minimal use case which only uses karma-sinon-chai.

@reintroducing
Copy link

reintroducing commented Jul 24, 2016

I'm also having this issue and I have the same dependencies as @callmevlad. In my config I commented out sinon-chai and that fixed it so I believe it is still something with this module. I'm not even running my tests through CI, this is running locally, and I've just started the unit tests on a new project so I only have one test that does some really random assertions just to make sure all my configuration is working properly so I can start writing a test suite.

Here is my frameworks in my config:

frameworks: [
    // 'sinon-chai',
    'sinon',
    'chai',
    'mocha'
]

I'd be happy to provide any information you deem fit to try and help resolve this.

@reintroducing
Copy link

aaaaaaand foot in mouth, removing the other frameworks from my frameworks array and using just sinon-chai works fine :\ Thats what I get for copy pasting configs, realized this only when I pasted my own frameworks in the prior comment a minute ago, sigh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants