Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to parse version "25.1-jre-graal-sub-1" #216

Open
kmate-ct opened this issue Jan 31, 2024 · 2 comments
Open

Unable to parse version "25.1-jre-graal-sub-1" #216

kmate-ct opened this issue Jan 31, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@kmate-ct
Copy link

Bug

The library gives

InvalidVersionStringError(25.1-jre-graal-sub-1)

for the above version

Summary

Project Details

Version: 0.13.0
Scala Version: 2.12.18
Java Version: openjdk11

Description

Describe the bug

I expect that version to parse.

To Reproduce
Steps to reproduce the behavior:

SemVer.parse("25.1-jre-graal-sub-1")

Expected behavior

The version parses without error.

@kmate-ct kmate-ct added the bug Something isn't working label Jan 31, 2024
@kmate-ct
Copy link
Author

Well, never mind if this doesn't fit the scope of the lib. There are many wild libraries like this that doesn't really use SemVer, but something close to it. There are also things where there are 4 dot-separated digits... it'd be just great to have a library that compares these versions correctly off the shelf.

@kevin-lee
Copy link
Owner

@kmate-ct Sorry I just saw this issue. Well, as you mentioned, it's out of the scope of this library as 25.1-jre-graal-sub-1 is not a valid SemVer.
However, I agree that it would be good to support other versions. Let me see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants