Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs value - selector value or attribute ... #20

Closed
razvanioan opened this issue Nov 28, 2012 · 2 comments
Closed

Tabs value - selector value or attribute ... #20

razvanioan opened this issue Nov 28, 2012 · 2 comments

Comments

@razvanioan
Copy link

Hi Kevin,

Great work.

I have a feature request that I actually tweaked it myself for the first project I'm trying to use it, and wanted to share this over here.

All my slides are images, and the tabs nav, I would have liked to be alternate text from the images themselves....

So I've introduced a new parameter which can be called something like "panelTitleValue" with null default value.

In this case I use your default code....take the value from the specified selector object).

But if I specify something else in instance config (alt for instance) I take the attribute value of the specified selector object from your already existing "panelTitleSelector" parameter.

Regards,
Razvan

@KevinBatdorf
Copy link
Owner

Not a bad idea. So you have it working now?

@razvanioan
Copy link
Author

Yes, this one already extended by me and working...only wanted to share it
with all the rest...

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants