Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PHP locale for date format and month names #110

Closed
kevinpapst opened this issue Jan 27, 2018 · 3 comments
Closed

Set PHP locale for date format and month names #110

kevinpapst opened this issue Jan 27, 2018 · 3 comments
Labels
Milestone

Comments

@kevinpapst
Copy link
Member

kevinpapst commented Jan 27, 2018

Add subscriber that sets the locale by the current users language:
setlocale(LC_ALL, $locale1, $locale2);

Testing:

  • Invoices: the "timesheet" renderer displays a month name, which must be translated properly
  • Timesheets: the rate must be formatted correctly
@kevinpapst kevinpapst added the bug label Jan 27, 2018
@kevinpapst kevinpapst added this to the 0.3 milestone Jun 22, 2018
@kevinpapst
Copy link
Member Author

setlocale is not thread safe, so we do it in the view directly instead

@kevinpapst
Copy link
Member Author

kevinpapst commented Jun 24, 2018

The rate formatting is now managed with twig filter and language specific

@kevinpapst kevinpapst changed the title Set PHP locale Set PHP locale for date format and month names Jul 12, 2018
@lock
Copy link

lock bot commented Nov 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant