Calendar date picker not using i18n setting

[noyez]

Describe the bug
When user preference is set to English, so first day of week is Sunday, the date-picker still uses Monday as first day of week, although the main calendar view displays the correct order of days. See screenshot.

To Reproduce

1. Set users's preference to Enlish so calendar starts on Sunday
2. Add entry in timesheet.
3. Click on From field to bring up calendar
4. Observer calendar has first day of week as Monday.

Screenshots

Desktop/Smartphone
Please complete the following information if this seems to be a frontend issue:

• Firefox 74.0

Additional context
Add any other context about the problem here.

• Kimai version: 1.8
• PHP version: php-7.2

[kevinpapst]

English is just the translation, not the locale. Not all English speaking countries use Sunday as first day of the week. I'd say it's quite the opposite as many users have to use English, as Kimai is not translated to their own language.

Probably the first day of the week should be configurable, or in a more global scale => the users country / locale ...

But you are right that is should be consistent.
I am not sure why that is different, maybe the datepicker doesn't respect the first day of week setting from moment.js.

[kevinpapst]

I believe this was fixed in 1.9.
But with the next release I added a user specific setting for the "first day of week", see #1952 - so I am linking this issue with PR.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.