Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Kimai as WebApp #203

Closed
kevinpapst opened this issue Jul 10, 2018 · 18 comments · Fixed by #211
Closed

Install Kimai as WebApp #203

kevinpapst opened this issue Jul 10, 2018 · 18 comments · Fixed by #211
Labels
feature request help wanted needs a developer who want to add this feature
Milestone

Comments

@kevinpapst
Copy link
Member

Enable Kimai to be installed as WebApp on devices that support it (at least Android does).

See #198 (comment)

Other resources:

@kevinpapst kevinpapst added feature request help wanted needs a developer who want to add this feature installation labels Jul 10, 2018
@j0hannesr0th
Copy link
Contributor

So I've tried to fix this with adding the below meta tag in "templates/security/login.html.twig"
<meta name="mobile-web-app-capable" content="yes">
and it works perfectly. It's just not offering to install it as a WebApp. For everyone who adds it manually to homescreen it works fine. Maybe this is acceptable as a quick fix until add-to-homescren is fully implemented.

SVID_20180711_092014_1

I did some research and found this project: https://github.com/cubiq/add-to-homescreen - it's able to add it to the users homescreen on iOS 6+ and Android with a notification for the user to add it.

What do you think about it?

@kevinpapst
Copy link
Member Author

I have to read a bit about the consequences. I guess real "web-apps" would have at least some kind of fallback if there is no Internet connection. What happens if you start it without any accessible network?

@j0hannesr0th
Copy link
Contributor

This meta tag is basically just hiding the url bar. I've used this in other projects, too and haven't discovered any consequences. Of course it's possible to add a shortcut to the desktop without seting the meta tag, too.

Screenshot comparison of having no internet connection (flightmode enabled) and launching the app from desktop.
Screenshot_20180711_132904

@kevinpapst
Copy link
Member Author

Thanks for the feedback!!!!
I will research in the next weeks to find out more about the topic, as its new to me and I'd like to know more about it before adding it.
But I would accept a PR in the meantime if its urgent for you...

@parthakarmick
Copy link

Hello,

I have tried to install kimai_1.3.1. But after hitting Install button it gives blank black screen and noting happening. Need guidance here.

Thank you

@kevinpapst
Copy link
Member Author

please don't hijack random topics which don't have to do anything with your problem. and you are in the wrong repo: https://github.com/kimai/kimai

@kevinpapst
Copy link
Member Author

@hmr-it-jr I created a PR with app icons and web app metadata (the meta tag + manifest.json for standalone mode). Could you test it and see what happens on Android (I don't have one for testing)?!
See #211

@kevinpapst kevinpapst added this to the 0.3 milestone Jul 12, 2018
@j0hannesr0th
Copy link
Contributor

@kevinpapst I've tested the PR today. The icon works fine, and the login page, too. After login the responsivness is broken.
I've tested it on three different devices. Android 7.1, Android 8.1, iOS 11.4

Android 8.1:

Screenshot_20180714_093531 Screenshot_20180714_093540 Screenshot_20180714_093601

Android 7.1:

Screenshot_20180714_094404

iOS 11.4:

Whats_App_Image_2018_07_14_at_09_51_16 Whats_App_Image_2018_07_14_at_09_51_17 Whats_App_Image_2018_07_14_at_09_51_18

@kevinpapst
Copy link
Member Author

Wow, nice - thanks for the detailed feedback! 👍
The checkbox in the login page is fixed in another branch.

TODO:

  • the iOS icon needs a white background, I believe transparent is not possible
  • change the name to "Kimai 2" only
  • check responsiveness

I'll let you know when I fixed that stuff.

@kevinpapst
Copy link
Member Author

Updated the branch with updated icons and changed app short_name.
Couldn't figure out while the responsiveness is not working, still checking it out.

@j0hannesr0th
Copy link
Contributor

I've tested the updated branch and the hotfix and can confirm both work perfectly!

Updated App icon

Whats_App_Image_2018_07_15_at_15_42_33

iOS responsiveness works

Whats_App_Image_2018_07_15_at_15_50_43

Android responsiveness works

Whats_App_Image_2018_07_15_at_15_49_37

@kevinpapst
Copy link
Member Author

I still don't like the iOS icon, but as my frontend skills are very limited I would say we go with it.
Could you do a quick check on Android as well? I modified the icons and metatags as well.

@j0hannesr0th
Copy link
Contributor

j0hannesr0th commented Jul 15, 2018

I think the iOS icon is fine now. If it bothers someone really much he or she may send a pr.

To the Android icon: The icon title is fine now, but the icon itself was better before...
Unbenannt

@kevinpapst
Copy link
Member Author

LOL, so true. Thats an SVG bug... I will update the branch later.

@kevinpapst
Copy link
Member Author

Okay, hopefully last try, the last push includes:

  • updated android icons (fixed transparency)
  • removed two unused icons
  • included the responsiveness bugfix

@j0hannesr0th
Copy link
Contributor

Looks good now!


Whats_App_Image_2018_07_15_at_21_09_10

@kevinpapst
Copy link
Member Author

Thank @hmr-it-jr for all your support!!!!

Very much appreciated 👍

@lock
Copy link

lock bot commented Nov 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request help wanted needs a developer who want to add this feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants