Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in activities API #2765

Closed
Jelle-S opened this issue Sep 16, 2021 · 5 comments · Fixed by #2766
Closed

Bug in activities API #2765

Jelle-S opened this issue Sep 16, 2021 · 5 comments · Fixed by #2766
Labels
Milestone

Comments

@Jelle-S
Copy link
Contributor

Jelle-S commented Sep 16, 2021

In testing the API on the latest master revision, we are encountering some more errors:

Error on PATCH "[...]/api/activities/723". Response: 400 Bad Request
{
  "code": 400,
  "message": "Validation Failed",
  "errors": {
    "errors": [
      "This form should not contain extra fields."
    ]
  }
}

This error does not contain the "children" element, which is weird to me. It seems like it doesn't accept any field at all. Comparing the API docs from 1.14 to the latest master, nothing seems to have changed. But when we click on one of the 'activity' endpoints in the docs, we get an error:
kimai_api_docs_error

@Jelle-S Jelle-S added the bug label Sep 16, 2021
@kevinpapst kevinpapst mentioned this issue Sep 16, 2021
3 tasks
@kevinpapst
Copy link
Member

@Jelle-S any chance you could test the changes in #2766 ?

@kevinpapst
Copy link
Member

Btw. the issue was in the activity "edit form" and not directly in the API. I added a test to prevent that bug in the future.

@kevinpapst kevinpapst added this to the 1.15 milestone Sep 16, 2021
@Jelle-S
Copy link
Contributor Author

Jelle-S commented Sep 16, 2021

Thanks for the update! I'll try to test this tomorrow

@kevinpapst
Copy link
Member

Okay, then you can test master tomorrow 😁

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

2 participants