Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language specific money and date display #180

Merged
merged 3 commits into from
Jun 25, 2018
Merged

language specific money and date display #180

merged 3 commits into from
Jun 25, 2018

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Jun 24, 2018

  • Display month name according to the users locale, instead of being translated with the PHP system locale.
  • Display rates according to the users locale
  • Display date saccording to the users locale
  • Sneaked in a UI improved in the template list view (action buttons).
  • Added tests and checked code styles.
  • Language specific configurations for date formats

Fixes #110

@kevinpapst kevinpapst added this to the 0.3 milestone Jun 24, 2018
@kevinpapst kevinpapst changed the title improved date translation language specific money and date display Jun 24, 2018
@simonschaufi
Copy link
Contributor

Can you write a short step by step instruction how to test this?

@kevinpapst
Copy link
Member Author

Quick and simple:

  • Checkout branch
  • You need an installation with a lot of timesheet entries with different customers and currencies (us the test fixtures)
  • Switch the languages

Expected results:

  • the date format in the data tables should change (en = Y-m-D, de = d.m.Y)
  • the currency format should change for the rates (de: 1.234,54 €, en: 1,234.54 €)
  • the month name can be tested by changing the invoice template to "Timesheet" - there is a month name in the upper left invoice like "January 2018" - that must change accordingly to the user language as well

Copy link
Contributor

@simonschaufi simonschaufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@simonschaufi simonschaufi merged commit d4a46cf into master Jun 25, 2018
@simonschaufi simonschaufi deleted the php-locale branch June 25, 2018 14:41
@lock
Copy link

lock bot commented Nov 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants