make sure that minute_increment is not zero #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2860 +/- ##
=========================================
Coverage 92.52% 92.53%
- Complexity 7593 7596 +3
=========================================
Files 674 674
Lines 23385 23389 +4
=========================================
+ Hits 21638 21642 +4
Misses 1747 1747
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This could cause a Javascript bug in forms that use the DateTimePickerType and the system setting
Minute selection for From & Towith the valueUse configured value of the rounding ruleand then the rounding rule being zero.The form/browser tab would simply freeze, due to another bug in the underlying javascript date-time-picker.
Types of changes
Checklist
composer code-check)