Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow switching user displayed in calendar #3314

Merged
merged 3 commits into from May 18, 2022
Merged

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented May 18, 2022

Description

Only activated if user has permission view_other_timesheet.
Bildschirmfoto 2022-05-18 um 17 21 04

Being able to manipulate other users timesheets requires permissions:

  • delete_other_timesheet
  • create_other_timesheet
  • edit_other_timesheet

Fixes #1746
Fixes #1067

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #3314 (4391df5) into master (9138397) will decrease coverage by 0.00%.
The diff coverage is 91.30%.

@@             Coverage Diff              @@
##             master    #3314      +/-   ##
============================================
- Coverage     91.99%   91.99%   -0.01%     
- Complexity     7742     7746       +4     
============================================
  Files           739      741       +2     
  Lines         23374    23385      +11     
============================================
+ Hits          21503    21512       +9     
- Misses         1871     1873       +2     
Impacted Files Coverage Δ
...tor/Constraints/TimesheetZeroDurationValidator.php 95.00% <83.33%> (-5.00%) ⬇️
src/Controller/CalendarController.php 84.84% <84.21%> (-5.16%) ⬇️
src/Controller/TimesheetAbstractController.php 86.21% <100.00%> (+0.41%) ⬆️
src/Controller/TimesheetController.php 100.00% <100.00%> (ø)
src/Controller/TimesheetTeamController.php 97.84% <100.00%> (ø)
src/Form/CalendarForm.php 100.00% <100.00%> (ø)
src/Form/TimesheetPreCreateForm.php 100.00% <100.00%> (ø)
src/Repository/TagRepository.php 85.52% <0.00%> (-2.64%) ⬇️

@kevinpapst kevinpapst merged commit 3c71640 into master May 18, 2022
@kevinpapst kevinpapst deleted the calendar-user-switch branch May 18, 2022 19:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

Show calendar of user in calendar of admin Calendar view user switching
1 participant