Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes regexp for search timesheets by tag #978

Merged
merged 2 commits into from Jul 22, 2019
Merged

Conversation

tobybatch
Copy link
Member

Description

Fixes regexp for search timesheets by tag [#976]

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst
Copy link
Member

Would you mind adjusting one test as well, so we never run into this problem again?
You could simply replace Nothing with Noth-ing here:
https://github.com/kevinpapst/kimai2/blob/master/tests/API/TimesheetControllerTest.php#L680

@kevinpapst kevinpapst added the bug label Jul 22, 2019
@kevinpapst kevinpapst added this to the 1.1 milestone Jul 22, 2019
@kevinpapst kevinpapst merged commit dae8866 into kimai:master Jul 22, 2019
@kevinpapst
Copy link
Member

Thx @tobybatch 😃

@kevinpapst kevinpapst mentioned this pull request Jul 22, 2019
@lock
Copy link

lock bot commented Sep 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants