Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Force cache #44

Closed
debo opened this issue Feb 26, 2016 · 8 comments
Closed

[Question]: Force cache #44

debo opened this issue Feb 26, 2016 · 8 comments

Comments

@debo
Copy link

debo commented Feb 26, 2016

Is there a way with the current implementation to force the client to cache the response regardless the headers coming from the response? I would like to ask the response coming from an API but it is so badly implemented that it doesn't send back proper headers. What would be the best way to go about it?

@jeromegamez
Copy link
Contributor

Hey @debo! You can use the GreedyCacheStrategy, introduced with #38.

@debo
Copy link
Author

debo commented Feb 26, 2016

Hey @jeromegamez thanks for the head up, the documentation on here it's a bit meh unfortunately, I wasn't aware of that (read as I didn't even check the code to be honest :-P).

I'll have a look into it thanks.

@debo
Copy link
Author

debo commented Feb 26, 2016

@jeromegamez you made my day, that was amazing. Where do we have to sign to have this middleware integrated in the core? :D

@jeromegamez
Copy link
Contributor

It already is :D

@debo
Copy link
Author

debo commented Feb 26, 2016

@jeromegamez I meant this entire plugin to become part of GuzzleHttp core :)

@Kevinrob
Copy link
Owner

The documentation need some work 😄 (cf. #42).

@Kevinrob
Copy link
Owner

@debo can we close this issue? Have you able to use the GreedyCacheStrategy?

@debo
Copy link
Author

debo commented Feb 27, 2016

@Kevinrob oh yes sorry, I forgot to update the issue. Thanks a lot.

@debo debo closed this as completed Feb 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants